From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Laszlo Ersek <lersek@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] hw/i386/pc_sysfw: support two flash drives
Date: Tue, 03 Dec 2013 18:58:34 +0100 [thread overview]
Message-ID: <529E1BCA.903@redhat.com> (raw)
In-Reply-To: <87ob4xvofq.fsf@blackfin.pond.sub.org>
Il 03/12/2013 18:23, Markus Armbruster ha scritto:
>> > + /* push a new, "none" location on the location stack; overwrite its
>> > + * contents with the location saved in the option; print the error
>> > + * (includes location); pop the top
>> > + */
> Sure this comment is worthwhile? Your decision.
>
> I suspect we should have error_report_loc().
Or qemu_opts_loc_push.
In any case, the comment is necessary but shouldn't be. :)
Paolo
>> > + loc_push_none(&loc);
>> > + if (pflash_drv->opts != NULL) {
>> > + qemu_opts_loc_restore(pflash_drv->opts);
>> > + }
next prev parent reply other threads:[~2013-12-03 17:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-27 23:52 [Qemu-devel] [PATCH v2] hw/i386/pc_sysfw: support two flash drives Laszlo Ersek
2013-12-03 17:23 ` Markus Armbruster
2013-12-03 17:58 ` Paolo Bonzini [this message]
2013-12-03 22:08 ` Laszlo Ersek
2013-12-10 4:56 ` Laszlo Ersek
2013-12-10 7:48 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529E1BCA.903@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=lersek@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).