From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39878)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VnuFI-0003dT-54
	for qemu-devel@nongnu.org; Tue, 03 Dec 2013 12:59:00 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VnuF7-0005iY-Cb
	for qemu-devel@nongnu.org; Tue, 03 Dec 2013 12:58:52 -0500
Received: from mail-qe0-x22a.google.com ([2607:f8b0:400d:c02::22a]:62753)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VnuF7-0005iR-82
	for qemu-devel@nongnu.org; Tue, 03 Dec 2013 12:58:41 -0500
Received: by mail-qe0-f42.google.com with SMTP id b4so14531672qen.1
	for <qemu-devel@nongnu.org>; Tue, 03 Dec 2013 09:58:40 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <529E1BCA.903@redhat.com>
Date: Tue, 03 Dec 2013 18:58:34 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1385596372-12167-1-git-send-email-lersek@redhat.com>
	<87ob4xvofq.fsf@blackfin.pond.sub.org>
In-Reply-To: <87ob4xvofq.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2] hw/i386/pc_sysfw: support two flash
	drives
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Laszlo Ersek <lersek@redhat.com>, qemu-devel@nongnu.org

Il 03/12/2013 18:23, Markus Armbruster ha scritto:
>> > +            /* push a new, "none" location on the location stack; overwrite its
>> > +             * contents with the location saved in the option; print the error
>> > +             * (includes location); pop the top
>> > +             */
> Sure this comment is worthwhile?  Your decision.
> 
> I suspect we should have error_report_loc().

Or qemu_opts_loc_push.

In any case, the comment is necessary but shouldn't be. :)

Paolo

>> > +            loc_push_none(&loc);
>> > +            if (pflash_drv->opts != NULL) {
>> > +                qemu_opts_loc_restore(pflash_drv->opts);
>> > +            }