From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60809) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VnxNi-000855-Pa for qemu-devel@nongnu.org; Tue, 03 Dec 2013 16:19:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VnxNd-0005mt-Pk for qemu-devel@nongnu.org; Tue, 03 Dec 2013 16:19:46 -0500 Message-ID: <529E4AE6.9000306@redhat.com> Date: Tue, 03 Dec 2013 14:19:34 -0700 From: Eric Blake MIME-Version: 1.0 References: <1386087086-3691-1-git-send-email-mst@redhat.com> <1386087086-3691-8-git-send-email-mst@redhat.com> <20131203204139.GA5670@redhat.com> In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6RcrRbiDdIGP220FNnvwkmcm1u3RMdDOM" Subject: Re: [Qemu-devel] [PATCH 07/23] hw/pci/pcie_aer.c: fix buffer overruns on invalid state load List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , "Michael S. Tsirkin" Cc: QEMU Developers , Anthony Liguori , qemu-stable This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --6RcrRbiDdIGP220FNnvwkmcm1u3RMdDOM Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 12/03/2013 01:59 PM, Peter Maydell wrote: >=20 > If a QEMU with this patch sends data to a QEMU without it, then the > receiving end will think it should expect log_num array entries but the= > sending end is going to send log_max of them. Conversely, an old->new > migration is going to send fewer array entries than the destination > expects. Or have I misinterpreted how the VARRAY entries work? If a qemu sends data larger than the field, the source side is already compromised. All we care about is that the destination fails gracefully, rather than acting on the bogus information from the compromised source. Versioning is only necessary for correct migration data, and doesn't matter when the source is already compromised. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --6RcrRbiDdIGP220FNnvwkmcm1u3RMdDOM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSnkrmAAoJEKeha0olJ0NqnPAIAJtvqwBcaLvJKbFSibeNYns1 EAwQ48KMKJQIVsKsBkstCzW3nq7A6B1EeiobZrmSjWxZ7rIeb2hyZIQQxvbcn2l5 r2qfDaum0X3yslenfwrIykKi9mlZtjZxPbNQORWlpKz/GMPvMYjc3PwffdjykNDh glQ7bA5rfQV/Pf1rUKTtKDCsdrCdDzJTOc/GXqpo6UScWi7mFxa3DQI81jRZ9NEq sxyngT4cwk56CPQl4LWTaoOQtQCGTy0Mue7sIDKCgWOTwRs0i/oCI6VdB4vpS7sg b/9x2FgEOc9jSk5R+3e/qjF9TIHPiNJXdPa8p+82/e8IpCePR1lJq7rLB7XinWA= =Cbmp -----END PGP SIGNATURE----- --6RcrRbiDdIGP220FNnvwkmcm1u3RMdDOM--