From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40224) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vo07q-00033V-7p for qemu-devel@nongnu.org; Tue, 03 Dec 2013 19:15:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vo07l-0001hm-6O for qemu-devel@nongnu.org; Tue, 03 Dec 2013 19:15:34 -0500 Received: from [222.73.24.84] (port=3226 helo=song.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vo07k-0001gS-OS for qemu-devel@nongnu.org; Tue, 03 Dec 2013 19:15:29 -0500 Message-ID: <529E7098.7090409@cn.fujitsu.com> Date: Wed, 04 Dec 2013 08:00:24 +0800 From: Li Guang MIME-Version: 1.0 References: <1386061881-12720-1-git-send-email-lig.fnst@cn.fujitsu.com> <1386061881-12720-6-git-send-email-lig.fnst@cn.fujitsu.com> In-Reply-To: Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=ISO-8859-1; format=flowed Subject: Re: [Qemu-devel] [PATCH 5/5] hw/arm: add cubieboard support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite Cc: Peter Maydell , "qemu-devel@nongnu.org Developers" , =?ISO-8859-1?Q?Andreas_F=E4rber?= Peter Crosthwaite wrote: > On Tue, Dec 3, 2013 at 7:11 PM, liguang wrote: > >> Signed-off-by: liguang >> --- >> hw/arm/Makefile.objs | 2 +- >> hw/arm/cubieboard.c | 33 +++++++++++++++++++++++++++++++++ >> 2 files changed, 34 insertions(+), 1 deletions(-) >> create mode 100644 hw/arm/cubieboard.c >> >> diff --git a/hw/arm/Makefile.objs b/hw/arm/Makefile.objs >> index b9e5983..8be8d8e 100644 >> --- a/hw/arm/Makefile.objs >> +++ b/hw/arm/Makefile.objs >> @@ -4,4 +4,4 @@ obj-y += omap_sx1.o palm.o realview.o spitz.o stellaris.o >> obj-y += tosa.o versatilepb.o vexpress.o xilinx_zynq.o z2.o >> >> obj-y += armv7m.o exynos4210.o pxa2xx.o pxa2xx_gpio.o pxa2xx_pic.o >> -obj-y += omap1.o omap2.o strongarm.o allwinner-a10.o >> +obj-y += omap1.o omap2.o strongarm.o allwinner-a10.o cubieboard.o >> diff --git a/hw/arm/cubieboard.c b/hw/arm/cubieboard.c >> new file mode 100644 >> index 0000000..a5be21c >> --- /dev/null >> +++ b/hw/arm/cubieboard.c >> @@ -0,0 +1,33 @@ >> +#include "hw/sysbus.h" >> +#include "hw/devices.h" >> +#include "hw/boards.h" >> +#include "hw/arm/allwinner-a10.h" >> + >> + >> +static struct arm_boot_info cubieboard_binfo = { >> + .loader_start = A10_SDRAM_BASE, >> + .board_id = 0x1008, >> +}; >> + >> +static void cubieboard_init(QEMUMachineInitArgs *args) >> +{ >> + A10State *s = a10_init(get_system_memory(), args->ram_size); >> + >> + cubieboard_binfo.ram_size = args->ram_size; >> + cubieboard_binfo.kernel_filename = args->kernel_filename; >> + cubieboard_binfo.kernel_cmdline = args->kernel_cmdline; >> > I cant help but think that serial attachment needs to happen on the > board level. but im not sure how this can be made to work with the > un-qomified serial_mm_init, so no block from me unless Andreas has a > better idea. > > >> + arm_load_kernel(s->cpu,&cubieboard_binfo); >> +} >> + >> +static QEMUMachine cubieboard_machine = { >> + .name = "cubieboard", >> + .init = cubieboard_init, >> > I think you should add at least the long descriptor so -M help plays nice. > > OK, thanks!