From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38258) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vnzwg-0004Xp-FK for qemu-devel@nongnu.org; Tue, 03 Dec 2013 19:04:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vnzwa-0006au-Ai for qemu-devel@nongnu.org; Tue, 03 Dec 2013 19:04:02 -0500 Received: from mail-yh0-f48.google.com ([209.85.213.48]:53713) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vnzwa-0006ap-7M for qemu-devel@nongnu.org; Tue, 03 Dec 2013 19:03:56 -0500 Received: by mail-yh0-f48.google.com with SMTP id f73so10729220yha.35 for ; Tue, 03 Dec 2013 16:03:20 -0800 (PST) Sender: Richard Henderson Message-ID: <529E7141.2050203@twiddle.net> Date: Wed, 04 Dec 2013 13:03:13 +1300 From: Richard Henderson MIME-Version: 1.0 References: <1386107477-24165-1-git-send-email-peter.maydell@linaro.org> <1386107477-24165-11-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1386107477-24165-11-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 10/12] target-arm: A64: add support for conditional branches List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , qemu-devel@nongnu.org Cc: patches@linaro.org, Michael Matz , Alexander Graf , C Fontana , Dirk Mueller , Laurent Desnogues , kvmarm@lists.cs.columbia.edu On 12/04/2013 10:51 AM, Peter Maydell wrote: > + if (cond < 0x0e) { > + /* genuinely conditional branches */ > + int label_nomatch = gen_new_label(); > + arm_gen_test_cc(cond ^ 1, label_nomatch); > + gen_goto_tb(s, 0, addr); > + gen_set_label(label_nomatch); > + gen_goto_tb(s, 1, s->pc); Why swap the condition with "^ 1"? You can just as easily swap the goto_tb. I realize the A32 translator does it this way, but need we continue? Otherwise, Reviewed-by: Richard Henderson r~