From: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: kwolf@redhat.com, pbonzini@redhat.com, jcody@redhat.com,
qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH V6 4/6] qemu-img: add -l for snapshot in convert
Date: Wed, 04 Dec 2013 10:50:07 +0800 [thread overview]
Message-ID: <529E985F.5020702@linux.vnet.ibm.com> (raw)
In-Reply-To: <20131203110256.GB24604@stefanha-thinkpad.muc.redhat.com>
于 2013/12/3 19:02, Stefan Hajnoczi 写道:
> On Fri, Nov 22, 2013 at 12:27:10PM +0800, Wenchao Xia wrote:
>> diff --git a/qemu-img-cmds.hx b/qemu-img-cmds.hx
>> index da1d965..9a8153b 100644
>> --- a/qemu-img-cmds.hx
>> +++ b/qemu-img-cmds.hx
>> @@ -34,7 +34,7 @@ STEXI
>> ETEXI
>>
>> DEF("convert", img_convert,
>> - "convert [-c] [-p] [-q] [-n] [-f fmt] [-t cache] [-O output_fmt] [-o options] [-s snapshot_name] [-S sparse_size] filename [filename2 [...]] output_filename")
>> + "convert [-c] [-p] [-q] [-n] [-f fmt] [-t cache] [-O output_fmt] [-o options] [-s snapshot_id_or_name] [-l snapshot_param] [-S sparse_size] filename [filename2 [...]] output_filename")
>> STEXI
>> @item convert [-c] [-p] [-q] [-n] [-f @var{fmt}] [-t @var{cache}] [-O @var{output_fmt}] [-o @var{options}] [-s @var{snapshot_name}] [-S @var{sparse_size}] @var{filename} [@var{filename2} [...]] @var{output_filename}
>
> Does this line need to be updated too?
>
Yes, thanks for catching that.
next prev parent reply other threads:[~2013-12-04 2:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-22 4:27 [Qemu-devel] [PATCH V6 0/6] export internal snapshot by qemu-nbd Wenchao Xia
2013-11-22 4:27 ` [Qemu-devel] [PATCH V6 1/6] snapshot: distinguish id and name in load_tmp Wenchao Xia
2013-11-22 4:27 ` [Qemu-devel] [PATCH V6 2/6] qemu-nbd: support internal snapshot export Wenchao Xia
2013-11-22 4:27 ` [Qemu-devel] [PATCH V6 3/6] qemu-iotests: add 058 internal snapshot export with qemu-nbd case Wenchao Xia
2013-12-03 13:45 ` Stefan Hajnoczi
2013-12-04 2:52 ` Wenchao Xia
2013-11-22 4:27 ` [Qemu-devel] [PATCH V6 4/6] qemu-img: add -l for snapshot in convert Wenchao Xia
2013-12-03 11:02 ` Stefan Hajnoczi
2013-12-04 2:50 ` Wenchao Xia [this message]
2013-11-22 4:27 ` [Qemu-devel] [PATCH V6 5/6] qemu-iotests: add test for snapshot in qemu-img convert Wenchao Xia
2013-11-22 4:27 ` [Qemu-devel] [PATCH V6 6/6] qemu-nbd: add doc for option -f Wenchao Xia
2013-11-29 8:54 ` [Qemu-devel] [PATCH V6 0/6] export internal snapshot by qemu-nbd Wenchao Xia
2013-12-03 3:33 ` Wenchao Xia
2013-12-03 13:46 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529E985F.5020702@linux.vnet.ibm.com \
--to=xiawenc@linux.vnet.ibm.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).