From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60888)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <xiawenc@linux.vnet.ibm.com>) id 1Vo2Xl-0008O5-4p
	for qemu-devel@nongnu.org; Tue, 03 Dec 2013 21:50:38 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <xiawenc@linux.vnet.ibm.com>) id 1Vo2Xb-0004TC-Rh
	for qemu-devel@nongnu.org; Tue, 03 Dec 2013 21:50:28 -0500
Received: from e28smtp01.in.ibm.com ([122.248.162.1]:54987)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <xiawenc@linux.vnet.ibm.com>) id 1Vo2Xb-0004Su-6i
	for qemu-devel@nongnu.org; Tue, 03 Dec 2013 21:50:19 -0500
Received: from /spool/local
	by e28smtp01.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <xiawenc@linux.vnet.ibm.com>;
	Wed, 4 Dec 2013 08:20:13 +0530
Received: from d28relay03.in.ibm.com (d28relay03.in.ibm.com [9.184.220.60])
	by d28dlp01.in.ibm.com (Postfix) with ESMTP id 07183E0056
	for <qemu-devel@nongnu.org>; Wed,  4 Dec 2013 08:22:22 +0530 (IST)
Received: from d28av03.in.ibm.com (d28av03.in.ibm.com [9.184.220.65])
	by d28relay03.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	rB42o4CX47054864
	for <qemu-devel@nongnu.org>; Wed, 4 Dec 2013 08:20:05 +0530
Received: from d28av03.in.ibm.com (localhost [127.0.0.1])
	by d28av03.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id
	rB42o8sZ016675
	for <qemu-devel@nongnu.org>; Wed, 4 Dec 2013 08:20:08 +0530
Message-ID: <529E985F.5020702@linux.vnet.ibm.com>
Date: Wed, 04 Dec 2013 10:50:07 +0800
From: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <1385094432-1655-1-git-send-email-xiawenc@linux.vnet.ibm.com>
	<1385094432-1655-5-git-send-email-xiawenc@linux.vnet.ibm.com>
	<20131203110256.GB24604@stefanha-thinkpad.muc.redhat.com>
In-Reply-To: <20131203110256.GB24604@stefanha-thinkpad.muc.redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH V6 4/6] qemu-img: add -l for snapshot in
 convert
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: kwolf@redhat.com, pbonzini@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com

于 2013/12/3 19:02, Stefan Hajnoczi 写道:
> On Fri, Nov 22, 2013 at 12:27:10PM +0800, Wenchao Xia wrote:
>> diff --git a/qemu-img-cmds.hx b/qemu-img-cmds.hx
>> index da1d965..9a8153b 100644
>> --- a/qemu-img-cmds.hx
>> +++ b/qemu-img-cmds.hx
>> @@ -34,7 +34,7 @@ STEXI
>>   ETEXI
>>
>>   DEF("convert", img_convert,
>> -    "convert [-c] [-p] [-q] [-n] [-f fmt] [-t cache] [-O output_fmt] [-o options] [-s snapshot_name] [-S sparse_size] filename [filename2 [...]] output_filename")
>> +    "convert [-c] [-p] [-q] [-n] [-f fmt] [-t cache] [-O output_fmt] [-o options] [-s snapshot_id_or_name] [-l snapshot_param] [-S sparse_size] filename [filename2 [...]] output_filename")
>>   STEXI
>>   @item convert [-c] [-p] [-q] [-n] [-f @var{fmt}] [-t @var{cache}] [-O @var{output_fmt}] [-o @var{options}] [-s @var{snapshot_name}] [-S @var{sparse_size}] @var{filename} [@var{filename2} [...]] @var{output_filename}
>
> Does this line need to be updated too?
>
   Yes, thanks for catching that.