qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: "Benoît Canet" <benoit@irqsave.net>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, jcody@redhat.com, armbru@redhat.com,
	stefanha@redhat.com
Subject: Re: [Qemu-devel] [RFC V3 3/7] qapi: Add skeletton of command to query a drive bs graph.
Date: Wed, 04 Dec 2013 11:10:38 +0800	[thread overview]
Message-ID: <529E9D2E.3070205@redhat.com> (raw)
In-Reply-To: <1386077165-19577-4-git-send-email-benoit@irqsave.net>

On 2013年12月03日 21:26, Benoît Canet wrote:
> ---
>   blockdev.c       |  8 ++++++++
>   qapi-schema.json | 32 ++++++++++++++++++++++++++++++++
>   2 files changed, 40 insertions(+)
>
> diff --git a/blockdev.c b/blockdev.c
> index a474bb5..824e718 100644
> --- a/blockdev.c
> +++ b/blockdev.c
> @@ -1940,6 +1940,14 @@ void qmp_drive_backup(const char *device, const char *target,
>       }
>   }
>
> +BlockGraphNode * qmp_query_drive_graph(const char *device, Error **errp)
> +{
> +    /* the implementation of this function would recurse through the
> +     * BlockDriverState graph to build it's result

s/it's/its/

>
>   ##
> +# @BlockGraphNode
> +#
> +# Information about a node of the block driver state graph
> +#
> +# @node-name: the name of the node in the graph
> +#
> +# @drv: the name of the block format used by this node as described in
> +#       @BlockDeviceInfo.
> +#
> +# @children: a list of @BlockGraphNode being the children of this node
> +#
> +# Since 1.8

Since 2.0

> +##
> +{ 'type': 'BlockGraphNode',
> +  'data': { 'node-name': 'str', 'drv': 'str', 'children': ['BlockGraphNode'] } }
> +
> +##
> +# @query-drive-graph
> +#
> +# Get the block driver states graph for a given drive
> +#
> +# @device: the name of the device to get the graph from
> +#
> +# Returns: the root @BlockGraphNode
> +#
> +# Since 1.8

Same as above.

Fam

  reply	other threads:[~2013-12-04  3:11 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-03 13:25 [Qemu-devel] [RFC V3 0/7] Giving names to BlockDriverState graph nodes Benoît Canet
2013-12-03 13:25 ` [Qemu-devel] [RFC V3 1/7] block: Add bs->node_name to hold the name of a bs node of the bs graph Benoît Canet
2013-12-04 23:26   ` Eric Blake
2013-12-03 13:26 ` [Qemu-devel] [RFC V3 2/7] block: Allow the user to define "node-name" option Benoît Canet
2013-12-04 23:33   ` Eric Blake
2013-12-03 13:26 ` [Qemu-devel] [RFC V3 3/7] qapi: Add skeletton of command to query a drive bs graph Benoît Canet
2013-12-04  3:10   ` Fam Zheng [this message]
2013-12-04 23:46   ` Eric Blake
2013-12-05 14:24     ` Benoît Canet
2013-12-05 14:38       ` Eric Blake
2013-12-05 14:43         ` Benoît Canet
2013-12-05 14:59           ` Eric Blake
2013-12-05 16:37             ` Benoît Canet
2013-12-03 13:26 ` [Qemu-devel] [RFC V3 4/7] qmp: Allow block_passwd to manipulate bs graph nodes Benoît Canet
2013-12-04 23:56   ` Eric Blake
2013-12-05 14:12     ` Benoît Canet
2013-12-03 13:26 ` [Qemu-devel] [RFC V3 5/7] qmp: Allow block_resize " Benoît Canet
2013-12-05  0:01   ` Eric Blake
2013-12-03 13:26 ` [Qemu-devel] [RFC V3 6/7] block: Create authorizations mechanism for external snapshots Benoît Canet
2013-12-04  3:35   ` Fam Zheng
2013-12-04  5:22     ` Benoît Canet
2013-12-04  3:47   ` Fam Zheng
2013-12-04  5:20     ` Benoît Canet
2013-12-04  6:12       ` Fam Zheng
2013-12-04  6:34         ` Benoît Canet
2013-12-04  7:03           ` Fam Zheng
2013-12-05 14:52             ` Benoît Canet
2013-12-03 13:26 ` [Qemu-devel] [RFC V3 7/7] qmp: Allow to take external snapshots on bs graphs node Benoît Canet
2013-12-04  3:51   ` Fam Zheng
2013-12-04  5:15     ` Benoît Canet
2013-12-05  0:11   ` Eric Blake
2013-12-05 14:16     ` Benoît Canet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=529E9D2E.3070205@redhat.com \
    --to=famz@redhat.com \
    --cc=armbru@redhat.com \
    --cc=benoit@irqsave.net \
    --cc=jcody@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).