From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43230) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vo3V1-00011Z-9O for qemu-devel@nongnu.org; Tue, 03 Dec 2013 22:51:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vo3Uw-0005r8-9L for qemu-devel@nongnu.org; Tue, 03 Dec 2013 22:51:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51513) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vo3Uw-0005r2-05 for qemu-devel@nongnu.org; Tue, 03 Dec 2013 22:51:38 -0500 Message-ID: <529EA6BE.5090403@redhat.com> Date: Wed, 04 Dec 2013 11:51:26 +0800 From: Fam Zheng MIME-Version: 1.0 References: <1386077165-19577-1-git-send-email-benoit@irqsave.net> <1386077165-19577-8-git-send-email-benoit@irqsave.net> In-Reply-To: <1386077165-19577-8-git-send-email-benoit@irqsave.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC V3 7/7] qmp: Allow to take external snapshots on bs graphs node. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= , qemu-devel@nongnu.org Cc: kwolf@redhat.com, jcody@redhat.com, armbru@redhat.com, stefanha@redhat.com On 2013=E5=B9=B412=E6=9C=8803=E6=97=A5 21:26, Beno=C3=AEt Canet wrote: > Signed-off-by: Benoit Canet > --- > blockdev.c | 49 +++++++++++++++++++++++++++++++++++++++++------= -- > hmp.c | 4 +++- > qapi-schema.json | 13 ++++++++++--- > qmp-commands.hx | 11 ++++++++++- > 4 files changed, 64 insertions(+), 13 deletions(-) > > diff --git a/blockdev.c b/blockdev.c > index e314d62..68d4ad1 100644 > --- a/blockdev.c > +++ b/blockdev.c > @@ -940,14 +940,22 @@ static void blockdev_do_action(int kind, void *da= ta, Error **errp) > qmp_transaction(&list, errp); > } > > -void qmp_blockdev_snapshot_sync(const char *device, const char *snapsh= ot_file, > - bool has_format, const char *format, > - bool has_mode, enum NewImageMode mode, > - Error **errp) > +void qmp_blockdev_snapshot_sync(bool has_device, const char * device, > + bool has_node_name, const char * node_= name, > + const char * snapshot_file, > + bool has_snapshot_node_name, > + const char * snapshot_node_name, > + bool has_format, const char * format, Same question with some other function declarations and definitions in=20 this series: you are adding an extra whitespace between * and pointer=20 name, is it intended? Thanks, Fam