From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33367) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vo8Hl-0003qm-1t for qemu-devel@nongnu.org; Wed, 04 Dec 2013 03:58:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vo8Hc-0006jF-IS for qemu-devel@nongnu.org; Wed, 04 Dec 2013 03:58:20 -0500 Received: from mail-ee0-x22d.google.com ([2a00:1450:4013:c00::22d]:33961) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vo8Hc-0006i3-9C for qemu-devel@nongnu.org; Wed, 04 Dec 2013 03:58:12 -0500 Received: by mail-ee0-f45.google.com with SMTP id d49so2159212eek.18 for ; Wed, 04 Dec 2013 00:58:11 -0800 (PST) Sender: Paolo Bonzini Message-ID: <529EEE9F.50007@redhat.com> Date: Wed, 04 Dec 2013 09:58:07 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1386132925-16728-1-git-send-email-aik@ozlabs.ru> <1386132925-16728-2-git-send-email-aik@ozlabs.ru> In-Reply-To: <1386132925-16728-2-git-send-email-aik@ozlabs.ru> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/3] scsi-disk: close drive on START_STOP List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy Cc: qemu-devel@nongnu.org, Markus Armbruster Il 04/12/2013 05:55, Alexey Kardashevskiy ha scritto: > Normally the user is expected to eject DVD if it is not locked by > the guest. eject_device() makes few checks and calls bdrv_close() > if DVD is not in use. > > However it is still possible to eject DVD even if it is in use. > For that, QEMU sets "eject requested" flag, the guest reads it, issues > ALLOW_MEDIUM_REMOVAL(enable=1) and START_STOP(start=0). But in this case, > bdrv_close() is not called anywhere so it remains "inserted" in QEMU's > terms. This is expected behavior, and matches what IDE does. Markus, can you confirm? Paolo