From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33487)
	by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <pl@kamp.de>)
	id 1VoJcd-0000O1-Pw
	for qemu-devel@nongnu.org; Wed, 04 Dec 2013 16:04:45 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pl@kamp.de>) id 1VoJcY-0006ZV-7I
	for qemu-devel@nongnu.org; Wed, 04 Dec 2013 16:04:39 -0500
Received: from mx.ipv6.kamp.de ([2a02:248:0:51::16]:56998 helo=mx01.kamp.de)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <pl@kamp.de>)
	id 1VoJcX-0006Z6-SE
	for qemu-devel@nongnu.org; Wed, 04 Dec 2013 16:04:34 -0500
Message-ID: <529F98D4.5000107@kamp.de>
Date: Wed, 04 Dec 2013 22:04:20 +0100
From: Peter Lieven <pl@kamp.de>
MIME-Version: 1.0
References: <1385023877-26524-1-git-send-email-pl@kamp.de>
	<529F6CD6.30005@kamp.de> <529F7279.70808@weilnetz.de>
In-Reply-To: <529F7279.70808@weilnetz.de>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] RESEND: [PATCHv2 0/6] ui/vnc: update optimizations
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <sw@weilnetz.de>, qemu-devel@nongnu.org
Cc: corentincj@iksaif.net, hengqing.hu@gmail.com, anthony@codemonkey.ws

Am 04.12.2013 19:20, schrieb Stefan Weil:
> Am 04.12.2013 18:56, schrieb Peter Lieven:
>> Ping
>>
>> Am 21.11.2013 09:51, schrieb Peter Lieven:
>>> this series includes several optimizations for the ui/vnc guest to server and server to client
>>> update cycles. comments/reviews appreciated.
>>>
>>> v1->v2: - new patches 2,4,5
>>>         - patch3: added performance test [Anthony]
>>>         - patch3: further optimized the vnc_update_client by searching for the next zero bit
>>>           with find_next_zero_bit.
>>>         - patch3: further optimized vnc_dpy_switch by using bitmap_set to mask bits dirty.
>>>
>>> Peter
>>>
>>> Peter Lieven (6):
>>>   ui/vnc: introduce VNC_DIRTY_PIXELS_PER_BIT macro
>>>   ui/vnc: derive cmp_bytes from VNC_DIRTY_PIXELS_PER_BIT
>>>   ui/vnc: optimize dirty bitmap tracking
>>>   ui/vnc: optimize clearing in find_and_clear_dirty_height()
>>>   ui/vnc: optimize setting in vnc_dpy_update()
>>>   ui/vnc: disable adaptive update calculations if not needed
>>>
>>>  ui/vnc.c |  185 ++++++++++++++++++++++++++++++++++++--------------------------
>>>  ui/vnc.h |    9 ++-
>>>  2 files changed, 115 insertions(+), 79 deletions(-)
> Hallo Peter,
>
> there was an e-mail from Eric which you might consider in a 2nd version
> of your patch series.
>
> Please check also your patches using scripts/checkpatch.pl. Some of them
> currently produce warnings:
ups, i was sure to have checked this...
>
> total: 0 errors, 1 warnings, 139 lines
> checked0001-ui-vnc-introduce-VNC_DIRTY_PIXELS_PER_BIT-macro.patch
>
> total: 0 errors, 6 warnings, 212 lines
> checked0003-ui-vnc-optimize-dirty-bitmap-tracking.patch
>
> total: 0 errors, 1 warnings, 17 lines
> checked0005-ui-vnc-optimize-setting-in-vnc_dpy_update.patch
>
> I think it would also be reasonable to fix the coding style for this
> code location in a separate patch
> before modifying the else statement, but maybe this is optional:
>
>      else
> -        w_lim = w - (w_lim % 16);
> +        w_lim = w - (w_lim % VNC_DIRTY_PIXELS_PER_BIT);
i will wait for further feedback and fix all these in v3.

Thanks,
Peter