From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49691) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VoOhy-0003zc-VN for qemu-devel@nongnu.org; Wed, 04 Dec 2013 21:30:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VoOhr-0004Aw-LG for qemu-devel@nongnu.org; Wed, 04 Dec 2013 21:30:30 -0500 Received: from mail-pb0-f52.google.com ([209.85.160.52]:61946) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VoOhr-00049l-FP for qemu-devel@nongnu.org; Wed, 04 Dec 2013 21:30:23 -0500 Received: by mail-pb0-f52.google.com with SMTP id uo5so24647036pbc.25 for ; Wed, 04 Dec 2013 18:30:22 -0800 (PST) Message-ID: <529FE537.1080206@ozlabs.ru> Date: Thu, 05 Dec 2013 13:30:15 +1100 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <1386206394-21092-1-git-send-email-mdroth@linux.vnet.ibm.com> <1386206394-21092-8-git-send-email-mdroth@linux.vnet.ibm.com> In-Reply-To: <1386206394-21092-8-git-send-email-mdroth@linux.vnet.ibm.com> Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 07/14] spapr: add helper to retrieve a PHB/device DrcEntry List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth , qemu-devel@nongnu.org Cc: agraf@suse.de, ncmike@ncultra.org, paulus@samba.org, tyreld@linux.vnet.ibm.com, nfont@linux.vnet.ibm.com, qemu-ppc@nongnu.org On 12/05/2013 12:19 PM, Michael Roth wrote: > Signed-off-by: Michael Roth > --- > hw/ppc/spapr.c | 36 ++++++++++++++++++++++++++++++++++++ > include/hw/ppc/spapr.h | 2 ++ > 2 files changed, 38 insertions(+) > > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > index 0607559..2250ee1 100644 > --- a/hw/ppc/spapr.c > +++ b/hw/ppc/spapr.c > @@ -277,6 +277,42 @@ static size_t create_page_sizes_prop(CPUPPCState *env, uint32_t *prop, > return (p - prop) * sizeof(uint32_t); > } > > +DrcEntry *spapr_phb_to_drc_entry(uint64_t buid) > +{ > + int i; > + > + for (i = 0; i < SPAPR_DRC_TABLE_SIZE; i++) { > + if (drc_table[i].phb_buid == buid) { > + return &drc_table[i]; > + } > + } > + > + return NULL; > +} > + > +DrcEntry *spapr_find_drc_entry(int drc_index) > +{ > + int i, j; > + > + for (i = 0; i < SPAPR_DRC_TABLE_SIZE; i++) { > + DrcEntry *phb_entry = &drc_table[i]; > + if (phb_entry->drc_index == drc_index) { > + return phb_entry; > + } > + if (phb_entry->child_entries == NULL) { > + continue; > + } > + for (j = 0; j < SPAPR_DRC_PHB_SLOT_MAX; j++) { > + DrcEntry *entry = &phb_entry->child_entries[j]; > + if (entry->drc_index == drc_index) { > + return entry; > + } > + } > + } > + > + return NULL; > +} spapr_find_drc_entry() is used in patches 1/3/4 but defined only in 7th patch, so patches 1..6 won't compile which breaks bisect. -- Alexey