From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Alexander Graf <agraf@suse.de>,
Anthony Liguori <aliguori@amazon.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] qdev: Keep global allocation counter per bus
Date: Thu, 05 Dec 2013 11:33:06 +0100 [thread overview]
Message-ID: <52A05662.60204@redhat.com> (raw)
In-Reply-To: <877gbjbpjf.fsf@blackfin.pond.sub.org>
Il 05/12/2013 10:44, Markus Armbruster ha scritto:
> Incompatible change: device ide-cd moved to a different controller.
Yes, it should be stated in the commit message but it's expected as
discussed yesterday on IRC. The solution is not to use "-device" (which
was broken) if you care about backwards compatibility; use "-drive if=ide".
> Great fun when you try to live migrate across your patch.
>
> I'd expect isapc to have the same issue once its crash bug is fixed.
>
> First law of QEMU hacking: if your patch looks simple, it's probably
> wrong ;)
Yes, the question is how wrong and how the wrong balances the right.
Paolo
next prev parent reply other threads:[~2013-12-05 10:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-04 20:24 [Qemu-devel] [PATCH] qdev: Keep global allocation counter per bus Alexander Graf
2013-12-05 8:58 ` Paolo Bonzini
2013-12-05 9:44 ` Markus Armbruster
2013-12-05 10:33 ` Paolo Bonzini [this message]
2013-12-05 11:20 ` Markus Armbruster
2013-12-05 11:38 ` Paolo Bonzini
2013-12-05 10:23 ` Markus Armbruster
-- strict thread matches above, loose matches on Subject: below --
2014-02-03 19:36 Alexander Graf
2014-02-04 10:33 ` Markus Armbruster
2014-02-04 11:48 ` Paolo Bonzini
2014-02-04 12:14 ` Markus Armbruster
2014-02-05 17:25 ` Paolo Bonzini
2014-02-06 14:41 ` Markus Armbruster
2014-02-06 14:41 ` Alexander Graf
2014-02-06 15:11 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A05662.60204@redhat.com \
--to=pbonzini@redhat.com \
--cc=agraf@suse.de \
--cc=aliguori@amazon.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).