From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47648) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VoWFE-0001oz-1t for qemu-devel@nongnu.org; Thu, 05 Dec 2013 05:33:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VoWF5-0002h6-MS for qemu-devel@nongnu.org; Thu, 05 Dec 2013 05:33:20 -0500 Received: from mail-qa0-x22e.google.com ([2607:f8b0:400d:c00::22e]:51996) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VoWF5-0002gT-HE for qemu-devel@nongnu.org; Thu, 05 Dec 2013 05:33:11 -0500 Received: by mail-qa0-f46.google.com with SMTP id f11so7486102qae.12 for ; Thu, 05 Dec 2013 02:33:11 -0800 (PST) Sender: Paolo Bonzini Message-ID: <52A05662.60204@redhat.com> Date: Thu, 05 Dec 2013 11:33:06 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1386188688-6480-1-git-send-email-agraf@suse.de> <877gbjbpjf.fsf@blackfin.pond.sub.org> In-Reply-To: <877gbjbpjf.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qdev: Keep global allocation counter per bus List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Alexander Graf , Anthony Liguori , QEMU Developers Il 05/12/2013 10:44, Markus Armbruster ha scritto: > Incompatible change: device ide-cd moved to a different controller. Yes, it should be stated in the commit message but it's expected as discussed yesterday on IRC. The solution is not to use "-device" (which was broken) if you care about backwards compatibility; use "-drive if=ide". > Great fun when you try to live migrate across your patch. > > I'd expect isapc to have the same issue once its crash bug is fixed. > > First law of QEMU hacking: if your patch looks simple, it's probably > wrong ;) Yes, the question is how wrong and how the wrong balances the right. Paolo