From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44604)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VoXur-0007gt-45
	for qemu-devel@nongnu.org; Thu, 05 Dec 2013 07:20:31 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VoXul-0002d2-5V
	for qemu-devel@nongnu.org; Thu, 05 Dec 2013 07:20:25 -0500
Received: from mx1.redhat.com ([209.132.183.28]:23152)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VoXuk-0002cx-Tq
	for qemu-devel@nongnu.org; Thu, 05 Dec 2013 07:20:19 -0500
Received: from int-mx12.intmail.prod.int.phx2.redhat.com
	(int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rB5CKIOo001119
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 5 Dec 2013 07:20:18 -0500
Message-ID: <52A06F7A.2030006@redhat.com>
Date: Thu, 05 Dec 2013 13:20:10 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1385994239-19016-1-git-send-email-pbonzini@redhat.com>
	<1385995228-19585-1-git-send-email-pbonzini@redhat.com>
	<52A06F58.2070005@redhat.com>
In-Reply-To: <52A06F58.2070005@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/4] memory: cache min/max_access_size
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: uril@redhat.com
Cc: qemu-devel@nongnu.org

Il 05/12/2013 13:19, Uri Lublin ha scritto:
>>
>>       /* FIXME: support unaligned access? */
>> -    access_size = MAX(MIN(size, access_size_max), access_size_min);
>> +    access_size = MAX(MIN(size, mr->min_access_size),
>> mr->min_access_size);
> Hi Paolo,
> 
> Here it should be                       mr->max_access_size
> 
> [ btw, MAX(MIN(a,b), b) = b ]

Thanks.

Paolo