From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57521) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VoYmj-0002Z8-Ro for qemu-devel@nongnu.org; Thu, 05 Dec 2013 08:16:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VoYmd-0002ug-5c for qemu-devel@nongnu.org; Thu, 05 Dec 2013 08:16:05 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48954) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VoYmc-0002uQ-Uh for qemu-devel@nongnu.org; Thu, 05 Dec 2013 08:15:59 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rB5DFudu021539 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 5 Dec 2013 08:15:57 -0500 Message-ID: <52A07CB1.8060201@redhat.com> Date: Thu, 05 Dec 2013 15:16:33 +0200 From: Orit Wasserman MIME-Version: 1.0 References: <1385647278-30043-1-git-send-email-ehabkost@redhat.com> In-Reply-To: <1385647278-30043-1-git-send-email-ehabkost@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/9] vmstate code split + unit tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost , qemu-devel@nongnu.org, Juan Quintela On 11/28/2013 04:01 PM, Eduardo Habkost wrote: > This series separates the QEMUFile and VMState code from savevm.c, and adds a > few unit tests to the VMState code. > > Eduardo Habkost (9): > qemu-file: Make a few functions non-static > migration: Move QEMU_VM_* defines to migration/migration.h > savevm: Convert all tabs to spaces > savevm.c: Coding style fixes > savevm.c: Coding style fix > vmstate: Move VMState code to vmstate.c > qemu-file: Move QEMUFile code to qemu-file.c > savevm: Small comment about why timer QEMUFile/VMState code is in > savevm.c > tests: Some unit tests for vmstate.c > > Makefile.objs | 2 + > include/migration/migration.h | 11 + > include/migration/qemu-file.h | 4 + > qemu-file.c | 826 +++++++++++++++++++++ > savevm.c | 1590 ++--------------------------------------- > tests/.gitignore | 1 + > tests/Makefile | 4 + > tests/test-vmstate.c | 357 +++++++++ > vmstate.c | 650 +++++++++++++++++ > 9 files changed, 1921 insertions(+), 1524 deletions(-) > create mode 100644 qemu-file.c > create mode 100644 tests/test-vmstate.c > create mode 100644 vmstate.c > Series Reviewed-by: Orit Wasserman (with v2 of patch 8)