From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49897) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VoaKm-0000Tz-2g for qemu-devel@nongnu.org; Thu, 05 Dec 2013 09:55:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VoaKg-00078a-OT for qemu-devel@nongnu.org; Thu, 05 Dec 2013 09:55:20 -0500 Received: from mx.ipv6.kamp.de ([2a02:248:0:51::16]:40094 helo=mx01.kamp.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VoaKg-00078U-Ck for qemu-devel@nongnu.org; Thu, 05 Dec 2013 09:55:14 -0500 Message-ID: <52A093CE.60207@kamp.de> Date: Thu, 05 Dec 2013 15:55:10 +0100 From: Peter Lieven MIME-Version: 1.0 References: <1385546829-3839-1-git-send-email-pl@kamp.de> <20131205121528.GA12608@stefanha-thinkpad.redhat.com> In-Reply-To: <20131205121528.GA12608@stefanha-thinkpad.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCHv3 1.8 0/9] qemu-img convert optimizations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com Am 05.12.2013 13:15, schrieb Stefan Hajnoczi: > On Wed, Nov 27, 2013 at 11:07:00AM +0100, Peter Lieven wrote: >> this series adds some optimizations for qemu-img during convert which >> have been developed recently: >> - skipping input based on get_block_status >> - variable I/O buffer size >> - align write requests to cluster_size >> >> v2->v3: >> - added Paolos comments in Patch 1 >> - changed the comment in patch 7 [Paolo] >> - remove the patch to add sector progress output >> - added a new patch to decrease the progress update interval. >> >> v1->v2: >> - introduce opt_transfer_length in BlockLimits [Paolo] >> - remove knobs for iobuffer_size and alignment and >> use them unconditionally [Paolo] >> - calculate I/O buffer size by BlockLimits information [Paolo] >> - change the alignment patch to round down to the >> last and not to the next aligned sector [Paolo] >> - limit updates in the sector progress output >> - new patch to increase the default for min_sparse [Paolo] >> >> Peter Lieven (9): >> qemu-img: add support for skipping zeroes in input during convert >> qemu-img: fix usage instruction for qemu-img convert >> block/iscsi: set bdi->cluster_size >> block: add opt_transfer_length to BlockLimits >> block/iscsi: set bs->bl.opt_transfer_length >> qemu-img: dynamically adjust iobuffer size during convert >> qemu-img: round down request length to an aligned sector >> qemu-img: increase min_sparse to 128 sectors (64kb) >> qemu-img: decrease progress update interval on convert >> >> block/iscsi.c | 10 ++++ >> include/block/block_int.h | 3 ++ >> qemu-img.c | 131 +++++++++++++++++++++++++++------------------ >> qemu-img.texi | 2 +- >> 4 files changed, 93 insertions(+), 53 deletions(-) > Merged all except patch 8/9. > > Thanks, applied to my block tree: > https://github.com/stefanha/qemu/commits/block Thank you. As discussed I've sent the follow-up patch [PATCH] qemu-img: make progress output more accurate during convert to the list some minutes ago. Peter