From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49868)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VohbP-0003TO-Um
	for qemu-devel@nongnu.org; Thu, 05 Dec 2013 17:41:05 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VohbH-0006LH-QT
	for qemu-devel@nongnu.org; Thu, 05 Dec 2013 17:40:59 -0500
Received: from mail-yh0-x22e.google.com ([2607:f8b0:4002:c01::22e]:50068)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VohbH-0006LB-D2
	for qemu-devel@nongnu.org; Thu, 05 Dec 2013 17:40:51 -0500
Received: by mail-yh0-f46.google.com with SMTP id l109so13006414yhq.5
	for <qemu-devel@nongnu.org>; Thu, 05 Dec 2013 14:40:51 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <52A100EA.90404@twiddle.net>
Date: Fri, 06 Dec 2013 11:40:42 +1300
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1386280289-27636-1-git-send-email-peter.maydell@linaro.org>
	<1386280289-27636-2-git-send-email-peter.maydell@linaro.org>
	<52A0FD9D.4000104@twiddle.net>
	<CAFEAcA8z4eyNx9Ws-j5pKvia9TqUaWdv7dFxVD-YR18HwK7utA@mail.gmail.com>
In-Reply-To: <CAFEAcA8z4eyNx9Ws-j5pKvia9TqUaWdv7dFxVD-YR18HwK7utA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 01/13] target-arm: A64: add support for
	conditional select
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Patch Tracking <patches@linaro.org>, Michael Matz <matz@suse.de>, QEMU Developers <qemu-devel@nongnu.org>, Claudio Fontana <claudio.fontana@linaro.org>, Dirk Mueller <dmueller@suse.de>, Will Newton <will.newton@linaro.org>, Laurent Desnogues <laurent.desnogues@gmail.com>, =?UTF-8?B?QWxleCBCZW5uw6ll?= <alex.bennee@linaro.org>, "kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>, Christoffer Dall <christoffer.dall@linaro.org>

On 12/06/2013 11:31 AM, Peter Maydell wrote:
> On 5 December 2013 22:26, Richard Henderson <rth@twiddle.net> wrote:
>> On 12/06/2013 10:51 AM, Peter Maydell wrote:
>>> +    if (cond >= 0x0e) { /* condition "always" */
>>> +        tcg_src = read_cpu_reg(s, rn, sf);
>>> +        tcg_gen_mov_i64(tcg_rd, tcg_src);
>>
>> I wonder if it's worth adding that 0x0[ef] case to the generic condition
>> processing rather than keep replicating it everywhere.
>>
>>> +    } else {
>>> +        /* OPTME: we could use movcond here, at the cost of duplicating
>>> +         * a lot of the arm_gen_test_cc() logic.
>>> +         */
>>
>> Honestly, arm_gen_test_cc should get refactored to a real test (as opposed to
>> branch) sooner rather than later.
> 
> By "sooner rather than later" do you mean "as part of this patch series" ?

It might make later patch series easier.  But I won't insist.


r~