From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51989)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Vohli-0003ZR-8i
	for qemu-devel@nongnu.org; Thu, 05 Dec 2013 17:51:44 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Vohlc-0000jn-F8
	for qemu-devel@nongnu.org; Thu, 05 Dec 2013 17:51:38 -0500
Received: from mail-yh0-x22b.google.com ([2607:f8b0:4002:c01::22b]:34303)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Vohlc-0000jd-AZ
	for qemu-devel@nongnu.org; Thu, 05 Dec 2013 17:51:32 -0500
Received: by mail-yh0-f43.google.com with SMTP id a41so12656261yho.30
	for <qemu-devel@nongnu.org>; Thu, 05 Dec 2013 14:51:31 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <52A1036B.9030002@twiddle.net>
Date: Fri, 06 Dec 2013 11:51:23 +1300
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1386280289-27636-1-git-send-email-peter.maydell@linaro.org>
	<1386280289-27636-6-git-send-email-peter.maydell@linaro.org>
In-Reply-To: <1386280289-27636-6-git-send-email-peter.maydell@linaro.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 05/13] target-arm: A64: add support for
 2-src data processing and DIV
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: patches@linaro.org, Michael Matz <matz@suse.de>, Claudio Fontana <claudio.fontana@linaro.org>, Dirk Mueller <dmueller@suse.de>, Will Newton <will.newton@linaro.org>, Laurent Desnogues <laurent.desnogues@gmail.com>, =?ISO-8859-1?Q?Alex_Benn=E9e?= <alex.bennee@linaro.org>, kvmarm@lists.cs.columbia.edu, Christoffer Dall <christoffer.dall@linaro.org>

On 12/06/2013 10:51 AM, Peter Maydell wrote:
> +    switch (opcode) {
> +    case 2: /* UDIV */
> +        handle_div(s, FALSE, sf, rm, rn, rd);
> +        break;
> +    case 3: /* SDIV */
> +        handle_div(s, TRUE, sf, rm, rn, rd);
> +        break;

What are these all-caps TRUE/FALSE?  stdbool.h uses lower-case.

Otherwise,

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~