Re: [Qemu-devel] [PATCH 05/13] target-arm: A64: add support for 2-src data processing and DIV

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1110 bytes --]

On 12/05/2013 04:09 PM, Peter Maydell wrote:
> On 5 December 2013 22:51, Richard Henderson <rth@twiddle.net> wrote:
>> On 12/06/2013 10:51 AM, Peter Maydell wrote:
>>> +    switch (opcode) {
>>> +    case 2: /* UDIV */
>>> +        handle_div(s, FALSE, sf, rm, rn, rd);
>>> +        break;
>>> +    case 3: /* SDIV */
>>> +        handle_div(s, TRUE, sf, rm, rn, rd);
>>> +        break;
>>
>> What are these all-caps TRUE/FALSE?  stdbool.h uses lower-case.
> 
> Good question, I wonder what system header is managing to define
> those for us? (there are some other bits of the source tree which
> use them too I see).

I blame glib:

https://developer.gnome.org/glib/2.32/glib-Standard-Macros.html#TRUE:CAPS

There are cases in the code where we must use TRUE because we want to
ensure we are using the gboolean type (which is not necessarily the same
size as bool), but I also concur that the use of <stdbool.h> true is
much nicer than TRUE in any code unrelated to glib.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]