From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60540) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VoiI3-0004LS-3Q for qemu-devel@nongnu.org; Thu, 05 Dec 2013 18:25:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VoiHw-0002UL-LU for qemu-devel@nongnu.org; Thu, 05 Dec 2013 18:25:02 -0500 Received: from mx1.redhat.com ([209.132.183.28]:13967) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VoiHw-0002UB-Dc for qemu-devel@nongnu.org; Thu, 05 Dec 2013 18:24:56 -0500 Message-ID: <52A10B3B.8050303@redhat.com> Date: Thu, 05 Dec 2013 16:24:43 -0700 From: Eric Blake MIME-Version: 1.0 References: <1386280289-27636-1-git-send-email-peter.maydell@linaro.org> <1386280289-27636-6-git-send-email-peter.maydell@linaro.org> <52A1036B.9030002@twiddle.net> In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kGH763bhjjNkOEJDu043tRx118OVHSo45" Subject: Re: [Qemu-devel] [PATCH 05/13] target-arm: A64: add support for 2-src data processing and DIV List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , Richard Henderson Cc: Laurent Desnogues , Patch Tracking , Michael Matz , QEMU Developers , Claudio Fontana , Dirk Mueller , Will Newton , =?UTF-8?B?QWxleCBCZW5uw6ll?= , "kvmarm@lists.cs.columbia.edu" , Christoffer Dall This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --kGH763bhjjNkOEJDu043tRx118OVHSo45 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 12/05/2013 04:09 PM, Peter Maydell wrote: > On 5 December 2013 22:51, Richard Henderson wrote: >> On 12/06/2013 10:51 AM, Peter Maydell wrote: >>> + switch (opcode) { >>> + case 2: /* UDIV */ >>> + handle_div(s, FALSE, sf, rm, rn, rd); >>> + break; >>> + case 3: /* SDIV */ >>> + handle_div(s, TRUE, sf, rm, rn, rd); >>> + break; >> >> What are these all-caps TRUE/FALSE? stdbool.h uses lower-case. >=20 > Good question, I wonder what system header is managing to define > those for us? (there are some other bits of the source tree which > use them too I see). I blame glib: https://developer.gnome.org/glib/2.32/glib-Standard-Macros.html#TRUE:CAPS= There are cases in the code where we must use TRUE because we want to ensure we are using the gboolean type (which is not necessarily the same size as bool), but I also concur that the use of true is much nicer than TRUE in any code unrelated to glib. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --kGH763bhjjNkOEJDu043tRx118OVHSo45 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSoQs7AAoJEKeha0olJ0Nqo24H/jNtz5xkHU9X7OGAV+dg5OD/ GFOpAP23PEtXYGKrIQqw/bcU/+kE6P6yLoWNXySYtbOZ9QBzRrbbpXRa3niwOuni 6o88eDmB4d3VPReQL7fd/M+ivIEbBS7/a8OvYO51B/00d6FSeSV1AyL7CcUU+oAm sJ3wgb9kQEJUxETHF0gKOgIMIV14WNqCvWAfGfEAMXUN/M8rjCOmcED2j4obbr/k NIyy8uO1o3VGaBtLEuyZ1ymfXvAcFEEEFepsmvAfJ90PMw/UoXBeeCAy89atRzf1 Gx4zFK38sCRv7F+oMF8q2RduPY6kAhYqN3sJfy9UUMmtKDvGjnWPi1wJ+VjM7Es= =osmU -----END PGP SIGNATURE----- --kGH763bhjjNkOEJDu043tRx118OVHSo45--