From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35239)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VoiWl-0002og-BX
	for qemu-devel@nongnu.org; Thu, 05 Dec 2013 18:40:19 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VoiWc-00070j-O1
	for qemu-devel@nongnu.org; Thu, 05 Dec 2013 18:40:15 -0500
Received: from mail-yh0-x230.google.com ([2607:f8b0:4002:c01::230]:42170)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VoiWc-00070M-JJ
	for qemu-devel@nongnu.org; Thu, 05 Dec 2013 18:40:06 -0500
Received: by mail-yh0-f48.google.com with SMTP id f73so13124937yha.35
	for <qemu-devel@nongnu.org>; Thu, 05 Dec 2013 15:40:06 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <52A10ECD.9070209@twiddle.net>
Date: Fri, 06 Dec 2013 12:39:57 +1300
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1386280289-27636-1-git-send-email-peter.maydell@linaro.org>
	<1386280289-27636-14-git-send-email-peter.maydell@linaro.org>
In-Reply-To: <1386280289-27636-14-git-send-email-peter.maydell@linaro.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 13/13] target-arm: A64: add support for
 logical (immediate) insns
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: patches@linaro.org, Michael Matz <matz@suse.de>, Claudio Fontana <claudio.fontana@linaro.org>, Dirk Mueller <dmueller@suse.de>, Will Newton <will.newton@linaro.org>, Laurent Desnogues <laurent.desnogues@gmail.com>, =?ISO-8859-1?Q?Alex_Benn=E9e?= <alex.bennee@linaro.org>, kvmarm@lists.cs.columbia.edu, Christoffer Dall <christoffer.dall@linaro.org>

On 12/06/2013 10:51 AM, Peter Maydell wrote:
> From: Alexander Graf <agraf@suse.de>
> 
> This patch adds support for C3.4.4 Logical (immediate),
> which include AND, ANDS, ORR, EOR.
> 
> Signed-off-by: Alexander Graf <agraf@suse.de>
> [claudio: adapted to new decoder, function renaming,
>           removed a TCG temp variable]
> Signed-off-by: Claudio Fontana <claudio.fontana@linaro.org>
> [PMM: cleaned up some unnecessary code in logic_imm_decode_wmask
> and added clarifying commentary on what it's actually doing.
> Dropped an ext32u that's not needed if we've just done an AND.]
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  target-arm/translate-a64.c |  175 +++++++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 173 insertions(+), 2 deletions(-)

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~