* [Qemu-devel] [PATCH v3 0/2] Intel MPX feature support at Qemu
@ 2013-12-06 14:06 Liu, Jinsong
2013-12-06 15:09 ` Eric Blake
2013-12-06 15:42 ` Paolo Bonzini
0 siblings, 2 replies; 6+ messages in thread
From: Liu, Jinsong @ 2013-12-06 14:06 UTC (permalink / raw)
To: Paolo Bonzini, Gleb Natapov, H. Peter Anvin,
qemu-devel@nongnu.org, kvm
Intel has released Memory Protection Extensions (MPX) recently.
Please refer to http://download-software.intel.com/sites/default/files/319433-015.pdf
These 2 patches are version2 to support Intel MPX at qemu side.
Version 1:
* Fix cpuid leaf 0x0d bug which incorrectly parsed eax and ebx;
* Expose cpuid leaf (0xd, 3) and (0xd, 4) to guest;
Version 2:
* Add comments to explain cpuid error parse (of current qemu) didn't generate wrong result;
* Add some MPX related definiation, and hardcode sizes and offsets of xsave features 3 and 4. It also add corresponding part to kvm_get/put_xsave.
Version 3:
* patch v2 1/2 (bug fix) has been checked in qemu;
* add vmstate for migration;
* add 1 new patch for bndcfgs msr;
Thanks,
Jinsong
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH v3 0/2] Intel MPX feature support at Qemu
2013-12-06 14:06 [Qemu-devel] [PATCH v3 0/2] Intel MPX feature support at Qemu Liu, Jinsong
@ 2013-12-06 15:09 ` Eric Blake
2013-12-06 16:27 ` Liu, Jinsong
2013-12-06 15:42 ` Paolo Bonzini
1 sibling, 1 reply; 6+ messages in thread
From: Eric Blake @ 2013-12-06 15:09 UTC (permalink / raw)
To: Liu, Jinsong, Paolo Bonzini, Gleb Natapov, H. Peter Anvin,
qemu-devel@nongnu.org, kvm
[-- Attachment #1: Type: text/plain, Size: 721 bytes --]
On 12/06/2013 07:06 AM, Liu, Jinsong wrote:
> Intel has released Memory Protection Extensions (MPX) recently.
> Please refer to http://download-software.intel.com/sites/default/files/319433-015.pdf
>
> These 2 patches are version2 to support Intel MPX at qemu side.
You still aren't threading correctly, which makes it hard to track your
series. Please review http://wiki.qemu.org/Contribute/SubmitAPatch and
make sure your 'git send-email' settings allow for proper threading; a
good way to test that is to first send the patch series to yourself to
ensure your environment is set up correctly.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH v3 0/2] Intel MPX feature support at Qemu
2013-12-06 15:09 ` Eric Blake
@ 2013-12-06 16:27 ` Liu, Jinsong
2013-12-06 17:21 ` H. Peter Anvin
0 siblings, 1 reply; 6+ messages in thread
From: Liu, Jinsong @ 2013-12-06 16:27 UTC (permalink / raw)
To: Eric Blake, Paolo Bonzini, Gleb Natapov, H. Peter Anvin,
qemu-devel@nongnu.org, kvm
Eric Blake wrote:
> On 12/06/2013 07:06 AM, Liu, Jinsong wrote:
>> Intel has released Memory Protection Extensions (MPX) recently.
>> Please refer to
>> http://download-software.intel.com/sites/default/files/319433-015.pdf
>>
>> These 2 patches are version2 to support Intel MPX at qemu side.
>
> You still aren't threading correctly, which makes it hard to track
> your series. Please review
> http://wiki.qemu.org/Contribute/SubmitAPatch and make sure your 'git
> send-email' settings allow for proper threading; a good way to test
> that is to first send the patch series to yourself to ensure your
> environment is set up correctly.
Thanks Blake! will take care and learn using git send-email when I send patches later (i.e. kvm mpx patches).
Jinsong
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH v3 0/2] Intel MPX feature support at Qemu
2013-12-06 16:27 ` Liu, Jinsong
@ 2013-12-06 17:21 ` H. Peter Anvin
0 siblings, 0 replies; 6+ messages in thread
From: H. Peter Anvin @ 2013-12-06 17:21 UTC (permalink / raw)
To: Liu, Jinsong, Eric Blake, Paolo Bonzini, Gleb Natapov,
qemu-devel@nongnu.org, kvm
On 12/06/2013 08:27 AM, Liu, Jinsong wrote:
> Eric Blake wrote:
>> On 12/06/2013 07:06 AM, Liu, Jinsong wrote:
>>> Intel has released Memory Protection Extensions (MPX) recently.
>>> Please refer to
>>> http://download-software.intel.com/sites/default/files/319433-015.pdf
>>>
>>> These 2 patches are version2 to support Intel MPX at qemu side.
>>
>> You still aren't threading correctly, which makes it hard to track
>> your series. Please review
>> http://wiki.qemu.org/Contribute/SubmitAPatch and make sure your 'git
>> send-email' settings allow for proper threading; a good way to test
>> that is to first send the patch series to yourself to ensure your
>> environment is set up correctly.
>
> Thanks Blake! will take care and learn using git send-email when I send patches later (i.e. kvm mpx patches).
>
Not to mention that Linux kernel patches should be Cc:'d to
<linux-kernel@vger.kernel.org>.
-hpa
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH v3 0/2] Intel MPX feature support at Qemu
2013-12-06 14:06 [Qemu-devel] [PATCH v3 0/2] Intel MPX feature support at Qemu Liu, Jinsong
2013-12-06 15:09 ` Eric Blake
@ 2013-12-06 15:42 ` Paolo Bonzini
2013-12-06 16:29 ` Liu, Jinsong
1 sibling, 1 reply; 6+ messages in thread
From: Paolo Bonzini @ 2013-12-06 15:42 UTC (permalink / raw)
To: Liu, Jinsong; +Cc: kvm, qemu-devel@nongnu.org, Gleb Natapov, H. Peter Anvin
Il 06/12/2013 15:06, Liu, Jinsong ha scritto:
> Intel has released Memory Protection Extensions (MPX) recently.
> Please refer to http://download-software.intel.com/sites/default/files/319433-015.pdf
>
> These 2 patches are version2 to support Intel MPX at qemu side.
> Version 1:
> * Fix cpuid leaf 0x0d bug which incorrectly parsed eax and ebx;
> * Expose cpuid leaf (0xd, 3) and (0xd, 4) to guest;
>
> Version 2:
> * Add comments to explain cpuid error parse (of current qemu) didn't generate wrong result;
> * Add some MPX related definiation, and hardcode sizes and offsets of xsave features 3 and 4. It also add corresponding part to kvm_get/put_xsave.
>
> Version 3:
> * patch v2 1/2 (bug fix) has been checked in qemu;
> * add vmstate for migration;
> * add 1 new patch for bndcfgs msr;
>
> Thanks,
> Jinsong--
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
I'm going to squash and apply the patches, but please please learn to
thread the messages correctly. You're also sending two copies of the
patch, one in the body and one in the attachment.
Paolo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH v3 0/2] Intel MPX feature support at Qemu
2013-12-06 15:42 ` Paolo Bonzini
@ 2013-12-06 16:29 ` Liu, Jinsong
0 siblings, 0 replies; 6+ messages in thread
From: Liu, Jinsong @ 2013-12-06 16:29 UTC (permalink / raw)
To: Paolo Bonzini, Eric Blake
Cc: kvm, qemu-devel@nongnu.org, Gleb Natapov, H. Peter Anvin
Paolo Bonzini wrote:
> Il 06/12/2013 15:06, Liu, Jinsong ha scritto:
>> Intel has released Memory Protection Extensions (MPX) recently.
>> Please refer to
>> http://download-software.intel.com/sites/default/files/319433-015.pdf
>>
>> These 2 patches are version2 to support Intel MPX at qemu side.
>> Version 1:
>> * Fix cpuid leaf 0x0d bug which incorrectly parsed eax and ebx;
>> * Expose cpuid leaf (0xd, 3) and (0xd, 4) to guest;
>>
>> Version 2:
>> * Add comments to explain cpuid error parse (of current qemu) didn't
>> generate wrong result;
>> * Add some MPX related definiation, and hardcode sizes and offsets
>> of xsave features 3 and 4. It also add corresponding part to
>> kvm_get/put_xsave.
>>
>> Version 3:
>> * patch v2 1/2 (bug fix) has been checked in qemu;
>> * add vmstate for migration;
>> * add 1 new patch for bndcfgs msr;
>>
>> Thanks,
>> Jinsong--
>> To unsubscribe from this list: send the line "unsubscribe kvm" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> I'm going to squash and apply the patches, but please please learn to
> thread the messages correctly. You're also sending two copies of the
> patch, one in the body and one in the attachment.
>
> Paolo
Yup, Blake also remind me threading. I will take care when sending kvm side patches.
Thanks,
Jinsong
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-12-06 17:21 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-06 14:06 [Qemu-devel] [PATCH v3 0/2] Intel MPX feature support at Qemu Liu, Jinsong
2013-12-06 15:09 ` Eric Blake
2013-12-06 16:27 ` Liu, Jinsong
2013-12-06 17:21 ` H. Peter Anvin
2013-12-06 15:42 ` Paolo Bonzini
2013-12-06 16:29 ` Liu, Jinsong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).