Re: [Qemu-devel] [PATCH V4 3/7] qmp: Add a command to list the named BlockDriverState nodes.

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1310 bytes --]

On 12/05/2013 10:14 AM, Benoît Canet wrote:
> Signed-off-by: Benoit Canet <benoit@irqsave.net>
> ---
>  block.c               | 16 ++++++++++++++++
>  blockdev.c            |  5 +++++
>  include/block/block.h |  1 +
>  qapi-schema.json      | 11 +++++++++++
>  qmp-commands.hx       | 19 +++++++++++++++++++
>  5 files changed, 52 insertions(+)

>  ##
> +# @query-named-block-nodes
> +#
> +# Get the named block driver list
> +#
> +# Returns: the list of named nodes names

Sounds funny.  Maybe better with just:

Returns: the list of names

> +#
> +# Since 2.0
> +##
> +{ 'command': 'query-named-block-nodes', 'returns': [ 'str' ] }

Also, is list of names sufficient, or are we better off returning a list
of structs with the details already included?  With list of names, the
management app has to follow up with another QMP command per name if it
wants to know details about each node, instead of getting it all in one
command.

> +SQMP
> +@query-named-block-nodes
> +------------------------
> +
> +Return a list of string containing the name of the named block driver states

Return a list of strings containing the name of each named block driver node

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]