From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52582) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Voxoh-0006aU-Ng for qemu-devel@nongnu.org; Fri, 06 Dec 2013 10:59:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Voxod-00016f-8z for qemu-devel@nongnu.org; Fri, 06 Dec 2013 10:59:47 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58134) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Voxoc-00016Z-Vm for qemu-devel@nongnu.org; Fri, 06 Dec 2013 10:59:43 -0500 Message-ID: <52A1F46A.9000307@redhat.com> Date: Fri, 06 Dec 2013 08:59:38 -0700 From: Eric Blake MIME-Version: 1.0 References: <1386263703-19292-1-git-send-email-benoit@irqsave.net> <1386263703-19292-4-git-send-email-benoit@irqsave.net> In-Reply-To: <1386263703-19292-4-git-send-email-benoit@irqsave.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="GbOVwFB8l75PrSjNxLwbvWpRbwaBXqGBD" Subject: Re: [Qemu-devel] [PATCH V4 3/7] qmp: Add a command to list the named BlockDriverState nodes. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= , qemu-devel@nongnu.org Cc: kwolf@redhat.com, jcody@redhat.com, famz@redhat.com, armbru@redhat.com, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --GbOVwFB8l75PrSjNxLwbvWpRbwaBXqGBD Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 12/05/2013 10:14 AM, Beno=C3=AEt Canet wrote: > Signed-off-by: Benoit Canet > --- > block.c | 16 ++++++++++++++++ > blockdev.c | 5 +++++ > include/block/block.h | 1 + > qapi-schema.json | 11 +++++++++++ > qmp-commands.hx | 19 +++++++++++++++++++ > 5 files changed, 52 insertions(+) > ## > +# @query-named-block-nodes > +# > +# Get the named block driver list > +# > +# Returns: the list of named nodes names Sounds funny. Maybe better with just: Returns: the list of names > +# > +# Since 2.0 > +## > +{ 'command': 'query-named-block-nodes', 'returns': [ 'str' ] } Also, is list of names sufficient, or are we better off returning a list of structs with the details already included? With list of names, the management app has to follow up with another QMP command per name if it wants to know details about each node, instead of getting it all in one command. > +SQMP > +@query-named-block-nodes > +------------------------ > + > +Return a list of string containing the name of the named block driver = states Return a list of strings containing the name of each named block driver n= ode --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --GbOVwFB8l75PrSjNxLwbvWpRbwaBXqGBD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSofRqAAoJEKeha0olJ0NqINMH/Rnh6ZdlRKOCnXb0G3HckAFk 8ONRcJUnrovYuAeKPbUlx3QGGl1hp7Fn+DbuJoPSEgAjDzhuJWRbQiV1/WNeKUe8 e8zmMEp/r1u8vKmTSeo9TZgRA0k+cZmiPKpoNYfw9dFAj5OwsfDzo7QN60h3ipbT YeqO9uatP1Db2/aVqXkscoT7atNJAStkUfa3bQ/uNywpgwcnyOlhQ6s2AksbPRvF BxmUNMR0ly5+mWzgCzIvWVINLebhN6UOnal3l6thukqdbgInZ/ytZGh8hYr4ni1I ywrOebTS+8WpUQsh6xTe+hRCAv6fMmDgPQT48n4G6oCpfiGiavVmpwsz+nHpM8s= =EhD3 -----END PGP SIGNATURE----- --GbOVwFB8l75PrSjNxLwbvWpRbwaBXqGBD--