From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52059)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VozWF-00019r-15
	for qemu-devel@nongnu.org; Fri, 06 Dec 2013 12:48:55 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VozW9-0001yY-W4
	for qemu-devel@nongnu.org; Fri, 06 Dec 2013 12:48:50 -0500
Received: from mail-yh0-x22a.google.com ([2607:f8b0:4002:c01::22a]:40912)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VozW9-0001yT-RR
	for qemu-devel@nongnu.org; Fri, 06 Dec 2013 12:48:45 -0500
Received: by mail-yh0-f42.google.com with SMTP id z6so724568yhz.1
	for <qemu-devel@nongnu.org>; Fri, 06 Dec 2013 09:48:45 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <52A20DF6.9070801@twiddle.net>
Date: Sat, 07 Dec 2013 06:48:38 +1300
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <CAFEAcA8DyS8ftustsMmQWGxmhMUNujVN25m+5d6XCPxQVj3d0A@mail.gmail.com>
	<1385538611-8149-1-git-send-email-sebastian.huber@embedded-brains.de>
In-Reply-To: <1385538611-8149-1-git-send-email-sebastian.huber@embedded-brains.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2] SPARC: Fix LEON3 power down instruction
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Sebastian Huber <sebastian.huber@embedded-brains.de>, qemu-devel@nongnu.org
Cc: Peter Meydell <peter.maydell@linaro.org>, Fabien Chouteau <chouteau@adacore.com>

On 11/27/2013 08:50 PM, Sebastian Huber wrote:
> Synchronize the program counter before the power down helper call
> otherwise interrupts will return to the wrong context.
> 
> Signed-off-by: Sebastian Huber <sebastian.huber@embedded-brains.de>
> ---
>  target-sparc/translate.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/target-sparc/translate.c b/target-sparc/translate.c
> index 05639ef..7481c85 100644
> --- a/target-sparc/translate.c
> +++ b/target-sparc/translate.c
> @@ -3630,6 +3630,7 @@ static void disas_sparc_insn(DisasContext * dc, unsigned int insn)
>                                  if ((rd == 0x13) && (dc->def->features &
>                                                       CPU_FEATURE_POWERDOWN)) {
>                                      /* LEON3 power-down */
> +                                    save_state(dc);
>                                      gen_helper_power_down(cpu_env);
>                                  }
>                                  break;
> 

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~