From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53014) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vozai-0003uH-Us for qemu-devel@nongnu.org; Fri, 06 Dec 2013 12:53:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vozad-0003R3-0r for qemu-devel@nongnu.org; Fri, 06 Dec 2013 12:53:28 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42438) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vozac-0003Qs-On for qemu-devel@nongnu.org; Fri, 06 Dec 2013 12:53:22 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rB6HrMdP012879 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 6 Dec 2013 12:53:22 -0500 Message-ID: <52A20F0E.8070001@redhat.com> Date: Fri, 06 Dec 2013 18:53:18 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1386350580-5666-1-git-send-email-kwolf@redhat.com> <1386350580-5666-6-git-send-email-kwolf@redhat.com> In-Reply-To: <1386350580-5666-6-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH 05/19] raw: Probe required direct I/O alignment List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, stefanha@redhat.com, armbru@redhat.com Il 06/12/2013 18:22, Kevin Wolf ha scritto: > @@ -1227,6 +1288,7 @@ static BlockDriver bdrv_file = { > .bdrv_aio_writev = raw_aio_writev, > .bdrv_aio_flush = raw_aio_flush, > .bdrv_aio_discard = raw_aio_discard, > + .bdrv_opt_mem_align = raw_opt_mem_align, > > .bdrv_truncate = raw_truncate, > .bdrv_getlength = raw_getlength, > @@ -1582,6 +1644,7 @@ static BlockDriver bdrv_host_device = { > .bdrv_aio_writev = raw_aio_writev, > .bdrv_aio_flush = raw_aio_flush, > .bdrv_aio_discard = hdev_aio_discard, > + .bdrv_opt_mem_align = raw_opt_mem_align, Should this rather be a BlockLimits field? Paolo