From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53235) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vozbh-0005Kj-0i for qemu-devel@nongnu.org; Fri, 06 Dec 2013 12:54:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vozbc-0003Z2-7A for qemu-devel@nongnu.org; Fri, 06 Dec 2013 12:54:28 -0500 Received: from mail-yh0-x234.google.com ([2607:f8b0:4002:c01::234]:49717) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vozbc-0003Yx-31 for qemu-devel@nongnu.org; Fri, 06 Dec 2013 12:54:24 -0500 Received: by mail-yh0-f52.google.com with SMTP id i72so721208yha.39 for ; Fri, 06 Dec 2013 09:54:23 -0800 (PST) Sender: Richard Henderson Message-ID: <52A20F49.1040901@twiddle.net> Date: Sat, 07 Dec 2013 06:54:17 +1300 From: Richard Henderson MIME-Version: 1.0 References: <1378747670-25512-1-git-send-email-aurelien@aurel32.net> <1378747670-25512-3-git-send-email-aurelien@aurel32.net> In-Reply-To: <1378747670-25512-3-git-send-email-aurelien@aurel32.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 2/4] tcg/optimize: fix known-zero bits optimization List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno , qemu-devel@nongnu.org Cc: Paolo Bonzini On 09/10/2013 05:27 AM, Aurelien Jarno wrote: > Known-zero bits optimization is a great idea that helps to generate more > optimized code. However the current implementation only works in very few > cases as the computed mask is not saved. > > Fix this to make it really working. > > Cc: Richard Henderson > Cc: Paolo Bonzini > Signed-off-by: Aurelien Jarno > --- > tcg/optimize.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) Reviewed-by: Richard Henderson r~