From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58954) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vp3Xr-0004zw-JA for qemu-devel@nongnu.org; Fri, 06 Dec 2013 17:06:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vp3Xj-0006zb-6g for qemu-devel@nongnu.org; Fri, 06 Dec 2013 17:06:47 -0500 Received: from mail-ee0-x236.google.com ([2a00:1450:4013:c00::236]:61308) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vp3Xi-0006zR-VS for qemu-devel@nongnu.org; Fri, 06 Dec 2013 17:06:39 -0500 Received: by mail-ee0-f54.google.com with SMTP id e51so543729eek.27 for ; Fri, 06 Dec 2013 14:06:38 -0800 (PST) Sender: Paolo Bonzini Message-ID: <52A24A6A.6000809@redhat.com> Date: Fri, 06 Dec 2013 23:06:34 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <20131206204715.16731.12627.stgit@bling.home> <20131206204842.16731.29998.stgit@bling.home> In-Reply-To: <20131206204842.16731.29998.stgit@bling.home> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL 4/5] vfio-pci: Add debug config options to disable MSI/X KVM support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Williamson Cc: qemu-devel@nongnu.org, aliguori@amazon.com, kvm@vger.kernel.org Il 06/12/2013 21:48, Alex Williamson ha scritto: > /* Extra debugging, trap acceleration paths for more logging */ > #define VFIO_ALLOW_MMAP 1 > #define VFIO_ALLOW_KVM_INTX 1 > +#define VFIO_ALLOW_KVM_MSI 1 > +#define VFIO_ALLOW_KVM_MSIX 1 Why not make these device properties instead? Paolo