From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49142) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vprkg-00005x-8H for qemu-devel@nongnu.org; Sun, 08 Dec 2013 22:43:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VprkX-00023b-2K for qemu-devel@nongnu.org; Sun, 08 Dec 2013 22:43:22 -0500 Received: from e23smtp09.au.ibm.com ([202.81.31.142]:51915) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VprkW-00022l-9f for qemu-devel@nongnu.org; Sun, 08 Dec 2013 22:43:12 -0500 Received: from /spool/local by e23smtp09.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 9 Dec 2013 13:43:09 +1000 Received: from d23relay05.au.ibm.com (d23relay05.au.ibm.com [9.190.235.152]) by d23dlp03.au.ibm.com (Postfix) with ESMTP id 274443578023 for ; Mon, 9 Dec 2013 14:43:07 +1100 (EST) Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.235.138]) by d23relay05.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id rB93Omk460227642 for ; Mon, 9 Dec 2013 14:24:48 +1100 Received: from d23av02.au.ibm.com (localhost [127.0.0.1]) by d23av02.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id rB93h6wi022668 for ; Mon, 9 Dec 2013 14:43:06 +1100 Message-ID: <52A53C49.4000601@linux.vnet.ibm.com> Date: Mon, 09 Dec 2013 11:43:05 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1386148259-10962-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1386148259-10962-5-git-send-email-xiawenc@linux.vnet.ibm.com> <529F939F.8020709@redhat.com> <52A017CD.2020508@linux.vnet.ibm.com> In-Reply-To: <52A017CD.2020508@linux.vnet.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V7 4/6] qemu-img: add -l for snapshot in convert List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: kwolf@redhat.com, pbonzini@redhat.com, jcody@redhat.com, stefanha@redhat.com >> >> convert -s snapshot.name=name1 >> > Previous I planned to use -l for internal snapshot in all possible > program, since -s is taken as external snapshot in qemu, qemu-nbd. > let -s stands for internal in qemu-img convert only, may bring > confuse to user, so I deprecated it instead of enhance it(I want > to remove it but may bring compatiablity issue). > Yes, it should report error when both specified, will send a patch > if you agree '-l' should still be used. > > Eric, I hope to get your idea before patching, any comments?