From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36914) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vq1BO-0001Bd-Lo for qemu-devel@nongnu.org; Mon, 09 Dec 2013 08:47:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vq1BI-0004fi-MG for qemu-devel@nongnu.org; Mon, 09 Dec 2013 08:47:34 -0500 Received: from mx1.redhat.com ([209.132.183.28]:14229) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vq1BI-0004fa-E2 for qemu-devel@nongnu.org; Mon, 09 Dec 2013 08:47:28 -0500 Message-ID: <52A5C9D4.7080404@redhat.com> Date: Mon, 09 Dec 2013 14:47:00 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1386349395-5710-1-git-send-email-imammedo@redhat.com> <1386349395-5710-8-git-send-email-imammedo@redhat.com> <52A20996.8020308@redhat.com> <20131209144139.7f9ac562@nial.usersys.redhat.com> In-Reply-To: <20131209144139.7f9ac562@nial.usersys.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 7/7] hw/pci: convert PCI bus to use "hotplug-device" interface. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: peter.maydell@linaro.org, ehabkost@redhat.com, marcel.a@redhat.com, mst@redhat.com, qemu-devel@nongnu.org, blauwirbel@gmail.com, alex.williamson@redhat.com, anthony@codemonkey.ws, afaerber@suse.de Il 09/12/2013 14:41, Igor Mammedov ha scritto: >> > Please move the parts under the "if" to hotplug.c (something like >> > hotplug_handler_plug and hotplug_handler_unplug). Also, should this be > sure. > >> > moved up to generic code (e.g. bus_add_child/bus_remove_child)? > Current usage hints that it's more realize() related part. If handler > fails device might want to do same device specific failure handling > before returning from realize() with failure. > It will work in bus_add_child/bus_remove_child as well but it would > basically put handlers to nofail category. Makes sense. realize() for the "plug" handler, and qdev_unplug for the unplug handler, I guess. Paolo