From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49614) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vq1xA-00083Z-7F for qemu-devel@nongnu.org; Mon, 09 Dec 2013 09:37:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vq1x2-0004NJ-DX for qemu-devel@nongnu.org; Mon, 09 Dec 2013 09:36:56 -0500 Received: from mx1.redhat.com ([209.132.183.28]:32250) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vq1x2-0004N6-5d for qemu-devel@nongnu.org; Mon, 09 Dec 2013 09:36:48 -0500 Message-ID: <52A5D573.7010803@redhat.com> Date: Mon, 09 Dec 2013 15:36:35 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1386349395-5710-1-git-send-email-imammedo@redhat.com> <1386349395-5710-8-git-send-email-imammedo@redhat.com> <52A20996.8020308@redhat.com> <20131209144139.7f9ac562@nial.usersys.redhat.com> <52A5C9D4.7080404@redhat.com> <20131209151431.57d49bd4@nial.usersys.redhat.com> In-Reply-To: <20131209151431.57d49bd4@nial.usersys.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 7/7] hw/pci: convert PCI bus to use "hotplug-device" interface. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: peter.maydell@linaro.org, ehabkost@redhat.com, marcel.a@redhat.com, mst@redhat.com, qemu-devel@nongnu.org, blauwirbel@gmail.com, alex.williamson@redhat.com, anthony@codemonkey.ws, afaerber@suse.de Il 09/12/2013 15:14, Igor Mammedov ha scritto: >> > >> > Makes sense. realize() for the "plug" handler, and qdev_unplug for the >> > unplug handler, I guess. > Just to be sure, I've meant not DEVICE.realize() but each device specific > one. If it's each specific device, then why should the hotplug handler link be in DeviceState? I think it should be in device_set_realized. > qdev_unplug() might work for now, but I haven't checked all devices that > might use interface and if it would break anything. Ideally it should be > in device's unrealize() complementing realize() part. > > I'd wait till all buses converted to new interface before attempting to > generalize current plug/unplug call pathes though. I agree that adding a default behavior for no link probably requires conversion of all buses. However, looking for the link in the generic code can be done now. Paolo