From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42749)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Vq50I-0006NF-N7
	for qemu-devel@nongnu.org; Mon, 09 Dec 2013 12:52:31 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Vq50A-0000CU-AG
	for qemu-devel@nongnu.org; Mon, 09 Dec 2013 12:52:22 -0500
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <52A60348.6050809@redhat.com>
Date: Mon, 09 Dec 2013 18:52:08 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1385112460-27156-1-git-send-email-pbonzini@redhat.com>
In-Reply-To: <1385112460-27156-1-git-send-email-pbonzini@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH for-1.7] spapr: tie spapr-nvram to -pflash
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>, qemu-ppc@nongnu.org, qemu-devel@nongnu.org, agraf@suse.de

Il 22/11/2013 10:27, Paolo Bonzini ha scritto:
> spapr-nvram's drive property is currently connected to a non-existent
> "-machine nvram=<drivename>" option.  Instead, tie it to -pflash like
> other non-volatile RAM devices.  This provides the following possibilities
> for adding a backend for the sPAPR non-volatile RAM:
> 
> * -pflash filename
> 
> * -drive if=pflash,file=filename,format=raw,...
> 
> * -drive if=none,file=filename,format=raw,id=foo,... -global spapr-nvram.drive=foo
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  hw/ppc/spapr.c | 14 +++-----------
>  1 file changed, 3 insertions(+), 11 deletions(-)
> 
> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> index 7e53a5f..38b43c9 100644
> --- a/hw/ppc/spapr.c
> +++ b/hw/ppc/spapr.c
> @@ -739,18 +739,10 @@ static void spapr_cpu_reset(void *opaque)
>  static void spapr_create_nvram(sPAPREnvironment *spapr)
>  {
>      DeviceState *dev = qdev_create(&spapr->vio_bus->bus, "spapr-nvram");
> -    const char *drivename = qemu_opt_get(qemu_get_machine_opts(), "nvram");
> +    DriveInfo *dinfo = drive_get(IF_PFLASH, 0, 0);
>  
> -    if (drivename) {
> -        BlockDriverState *bs;
> -
> -        bs = bdrv_find(drivename);
> -        if (!bs) {
> -            fprintf(stderr, "No such block device \"%s\" for nvram\n",
> -                    drivename);
> -            exit(1);
> -        }
> -        qdev_prop_set_drive_nofail(dev, "drive", bs);
> +    if (dinfo) {
> +        qdev_prop_set_drive_nofail(dev, "drive", dinfo->bdrv);
>      }
>  
>      qdev_init_nofail(dev);
> 

Ping?

Paolo