From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43078) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vq51T-0007yz-IW for qemu-devel@nongnu.org; Mon, 09 Dec 2013 12:53:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vq51I-0000mB-GZ for qemu-devel@nongnu.org; Mon, 09 Dec 2013 12:53:35 -0500 Received: from mail-qe0-x236.google.com ([2607:f8b0:400d:c02::236]:53655) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vq51I-0000m6-8c for qemu-devel@nongnu.org; Mon, 09 Dec 2013 12:53:24 -0500 Received: by mail-qe0-f54.google.com with SMTP id cy11so3069964qeb.13 for ; Mon, 09 Dec 2013 09:53:23 -0800 (PST) Sender: Paolo Bonzini Message-ID: <52A60390.9050600@redhat.com> Date: Mon, 09 Dec 2013 18:53:20 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1385745142-20520-1-git-send-email-lersek@redhat.com> In-Reply-To: <1385745142-20520-1-git-send-email-lersek@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 0/4] i440fx-test: check firmware visibility List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: qemu-devel@nongnu.org, Markus Armbruster Il 29/11/2013 18:12, Laszlo Ersek ha scritto: > v3 [Markus]: > - FW_SIZE -> BLOB_SIZE > - create_firmware() -> create_blob_file() > - detach create_blob_file() comment block from firmware & temporariness > - same in filename and error messages there > - char unsigned -> uint8_t Great idea. :) > > Laszlo Ersek (4): > i440fx-test: qtest_start() should be paired with qtest_end() > i440fx-test: give each GTest case its own qtest > i440fx-test: generate temporary firmware blob > i440fx-test: verify firmware under 4G and 1M, both -bios and -pflash > > tests/i440fx-test.c | 167 ++++++++++++++++++++++++++++++++++++++++++++++------ > 1 file changed, 150 insertions(+), 17 deletions(-) > Markus, can you give your Reviewed-by? Paolo