From: Paolo Bonzini <pbonzini@redhat.com>
To: Bandan Das <bsd@redhat.com>
Cc: qemu-devel@nongnu.org, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH 3/4] qdev: allow both pre- and post-order vists in qdev walking functions
Date: Mon, 09 Dec 2013 19:04:47 +0100 [thread overview]
Message-ID: <52A6063F.5070408@redhat.com> (raw)
In-Reply-To: <jpg38m1rjra.fsf@nelium.bos.redhat.com>
Il 09/12/2013 18:56, Bandan Das ha scritto:
>> > This is a generic walk function.
>> > For reset you want post-order, but in other cases pre-order may make
>> > more sense, for example realize.
> Sorry, not sure if I get it. What I meant was will this work ?
>
> int qbus_walk_children(BusState *bus, qdev_walkerfn *devfn,
> - qbus_walkerfn *busfn, void *opaque)
> + qbus_walkerfn *busfn, bool ispostorder, void *opaque)
Yes, but it is a bit less flexible.
> Or there's a case where we would like to traverse pre for parent and post
> for children's buses (or something similar)..
Probably not, but there may be a case where you want both pre and post
(i.e. before and after). For example a "display tree" functionality
where the post-order callbacks simply decrement the current indentation.
Paolo
next prev parent reply other threads:[~2013-12-09 18:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-06 16:54 [Qemu-devel] [PATCH 0/4] qdev: switch reset to post-order, clean up PCI reset Paolo Bonzini
2013-12-06 16:54 ` [Qemu-devel] [PATCH 1/4] pci: do not export pci_bus_reset Paolo Bonzini
2013-12-06 16:54 ` [Qemu-devel] [PATCH 2/4] pci: clean up resetting of IRQs Paolo Bonzini
2013-12-06 16:54 ` [Qemu-devel] [PATCH 3/4] qdev: allow both pre- and post-order vists in qdev walking functions Paolo Bonzini
2013-12-06 23:27 ` Bandan Das
2013-12-09 9:50 ` Paolo Bonzini
2013-12-09 17:56 ` Bandan Das
2013-12-09 18:04 ` Paolo Bonzini [this message]
2013-12-09 18:15 ` Bandan Das
2013-12-09 18:05 ` Paolo Bonzini
2013-12-06 16:54 ` [Qemu-devel] [PATCH 4/4] qdev: switch reset to post-order Paolo Bonzini
2013-12-19 18:23 ` Michael S. Tsirkin
2013-12-19 19:15 ` [Qemu-devel] [PATCH 0/4] qdev: switch reset to post-order, clean up PCI reset Michael S. Tsirkin
2013-12-19 23:45 ` Paolo Bonzini
-- strict thread matches above, loose matches on Subject: below --
2013-10-03 13:46 Paolo Bonzini
2013-10-03 13:46 ` [Qemu-devel] [PATCH 3/4] qdev: allow both pre- and post-order vists in qdev walking functions Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A6063F.5070408@redhat.com \
--to=pbonzini@redhat.com \
--cc=bsd@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).