From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60261)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Vq8VX-0003ek-H3
	for qemu-devel@nongnu.org; Mon, 09 Dec 2013 16:36:57 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Vq8VO-0000bE-0y
	for qemu-devel@nongnu.org; Mon, 09 Dec 2013 16:36:51 -0500
Received: from mail-pd0-x230.google.com ([2607:f8b0:400e:c02::230]:37304)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Vq8VN-0000b1-PR
	for qemu-devel@nongnu.org; Mon, 09 Dec 2013 16:36:41 -0500
Received: by mail-pd0-f176.google.com with SMTP id w10so5913123pde.7
	for <qemu-devel@nongnu.org>; Mon, 09 Dec 2013 13:36:40 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <52A637E5.4000301@twiddle.net>
Date: Mon, 09 Dec 2013 13:36:37 -0800
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1386612744-1013-1-git-send-email-peter.maydell@linaro.org>
	<1386612744-1013-7-git-send-email-peter.maydell@linaro.org>
In-Reply-To: <1386612744-1013-7-git-send-email-peter.maydell@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 6/9] target-arm: A64: add support for add,
 addi, sub, subi
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: patches@linaro.org, Michael Matz <matz@suse.de>, Claudio Fontana <claudio.fontana@linaro.org>, Dirk Mueller <dmueller@suse.de>, Will Newton <will.newton@linaro.org>, Laurent Desnogues <laurent.desnogues@gmail.com>, =?UTF-8?B?QWxleCBCZW5uw6ll?= <alex.bennee@linaro.org>, kvmarm@lists.cs.columbia.edu, Christoffer Dall <christoffer.dall@linaro.org>

On 12/09/2013 10:12 AM, Peter Maydell wrote:
> +        tcg_rn = read_cpu_reg_sp(s, rn, sf);
> +        tcg_gen_mov_i64(tcg_rn, cpu_reg_sp(s, rn));

Duplicate copy from the register.

Otherwise,

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~