From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34708)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Vq8lB-000283-0Y
	for qemu-devel@nongnu.org; Mon, 09 Dec 2013 16:53:09 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Vq8l2-0005Ey-KL
	for qemu-devel@nongnu.org; Mon, 09 Dec 2013 16:53:00 -0500
Received: from mail-pb0-x235.google.com ([2607:f8b0:400e:c01::235]:54950)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Vq8l2-0005Et-BX
	for qemu-devel@nongnu.org; Mon, 09 Dec 2013 16:52:52 -0500
Received: by mail-pb0-f53.google.com with SMTP id ma3so6174955pbc.26
	for <qemu-devel@nongnu.org>; Mon, 09 Dec 2013 13:52:51 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <52A63BAF.2000203@twiddle.net>
Date: Mon, 09 Dec 2013 13:52:47 -0800
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1386612744-1013-1-git-send-email-peter.maydell@linaro.org>
	<1386612744-1013-9-git-send-email-peter.maydell@linaro.org>
In-Reply-To: <1386612744-1013-9-git-send-email-peter.maydell@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 8/9] target-arm: A64: add support for 3 src
 data proc insns
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: patches@linaro.org, Michael Matz <matz@suse.de>, Claudio Fontana <claudio.fontana@linaro.org>, Dirk Mueller <dmueller@suse.de>, Will Newton <will.newton@linaro.org>, Laurent Desnogues <laurent.desnogues@gmail.com>, =?UTF-8?B?QWxleCBCZW5uw6ll?= <alex.bennee@linaro.org>, kvmarm@lists.cs.columbia.edu, Christoffer Dall <christoffer.dall@linaro.org>

On 12/09/2013 10:12 AM, Peter Maydell wrote:
> +    if (is_high) {
> +        /* SMULH and UMULH go via helpers for the 64x64->128 multiply */
> +        if (is_signed) {
> +            gen_helper_smulh(cpu_reg(s, rd), cpu_reg(s, rn), cpu_reg(s, rm));
> +        } else {
> +            gen_helper_umulh(cpu_reg(s, rd), cpu_reg(s, rn), cpu_reg(s, rm));
> +        }

Should use tcg_gen_mul[su]2_i64, with a dummy temp for the first arg; the
highpart result is placed into the second arg.



r~