From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35840)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Vq8qQ-0004io-TY
	for qemu-devel@nongnu.org; Mon, 09 Dec 2013 16:58:32 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Vq8qJ-0007Et-Gn
	for qemu-devel@nongnu.org; Mon, 09 Dec 2013 16:58:26 -0500
Received: from mail-pd0-x22d.google.com ([2607:f8b0:400e:c02::22d]:54105)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Vq8qJ-0007Eh-5p
	for qemu-devel@nongnu.org; Mon, 09 Dec 2013 16:58:19 -0500
Received: by mail-pd0-f173.google.com with SMTP id p10so5954245pdj.4
	for <qemu-devel@nongnu.org>; Mon, 09 Dec 2013 13:58:17 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <52A63CF5.4090100@twiddle.net>
Date: Mon, 09 Dec 2013 13:58:13 -0800
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1386612744-1013-1-git-send-email-peter.maydell@linaro.org>
	<1386612744-1013-10-git-send-email-peter.maydell@linaro.org>
In-Reply-To: <1386612744-1013-10-git-send-email-peter.maydell@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 9/9] target-arm: A64: implement SVC, BRK
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: patches@linaro.org, Michael Matz <matz@suse.de>, Claudio Fontana <claudio.fontana@linaro.org>, Dirk Mueller <dmueller@suse.de>, Will Newton <will.newton@linaro.org>, Laurent Desnogues <laurent.desnogues@gmail.com>, =?UTF-8?B?QWxleCBCZW5uw6ll?= <alex.bennee@linaro.org>, kvmarm@lists.cs.columbia.edu, Christoffer Dall <christoffer.dall@linaro.org>

On 12/09/2013 10:12 AM, Peter Maydell wrote:
> +    case 0:
> +        /* SVC, HVC, SMC; since we don't support the Virtualization
> +         * or TrustZone extensions these all UNDEF except SVC.
> +         */
> +        if (op2_ll != 1) {
> +            unallocated_encoding(s);
> +            break;
> +        }
> +        gen_exception_insn(s, 0, EXCP_SWI);
> +        break;

Should the imm16 should be stored somewhere, for exception.syndrome?

I can only presume from this that the AA64 userland doesn't encode its syscall
number in the insn...

Otherwise,

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~