From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48954)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VqAlX-00024V-S4
	for qemu-devel@nongnu.org; Mon, 09 Dec 2013 19:01:40 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VqAlP-0001ck-FO
	for qemu-devel@nongnu.org; Mon, 09 Dec 2013 19:01:31 -0500
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <52A659CE.6090202@twiddle.net>
Date: Mon, 09 Dec 2013 16:01:18 -0800
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1386604035-2507-1-git-send-email-tommusta@gmail.com>
	<1386604035-2507-3-git-send-email-tommusta@gmail.com>
In-Reply-To: <1386604035-2507-3-git-send-email-tommusta@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 02/18] target-ppc: Add ISA2.06 bpermd
	Instruction
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Tom Musta <tommusta@gmail.com>, qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org

On 12/09/2013 07:46 AM, Tom Musta wrote:
> +    for (i = 0; i < 8; i++) {
> +        int index = (rs & (0xFFul) << (i*8)) >> (i*8);

This is a silly expression.  Better as

    int index = (rs >> (i * 8)) & 0xff;

> +                ra |= (1<<i);

Unnecessary parens, and missing spaces around the operator.


r~