From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35568) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VqBOf-0004JR-4R for qemu-devel@nongnu.org; Mon, 09 Dec 2013 19:42:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VqBOW-0008WM-Dh for qemu-devel@nongnu.org; Mon, 09 Dec 2013 19:41:57 -0500 Sender: Richard Henderson Message-ID: <52A66348.8010902@twiddle.net> Date: Mon, 09 Dec 2013 16:41:44 -0800 From: Richard Henderson MIME-Version: 1.0 References: <1386604035-2507-1-git-send-email-tommusta@gmail.com> <1386604035-2507-8-git-send-email-tommusta@gmail.com> In-Reply-To: <1386604035-2507-8-git-send-email-tommusta@gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 07/18] target-ppc: Add ISA 2.06 stbcx. and sthcx. Instructions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Tom Musta , qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org On 12/09/2013 07:47 AM, Tom Musta wrote: > -static void gen_conditional_store (DisasContext *ctx, TCGv EA, > +static void gen_conditional_store(DisasContext *ctx, TCGv EA, > int reg, int size) If you're going to make random changes to the formatting, fix it all -- the indentation on the next line is now wrong. > + gen_qemu_##storeop(ctx, cpu_gpr[rS(ctx->opcode)], t0); \ I meant to mention this for l*arx too, but please use the new ldst opcodes. That'll save me having to make the change here in the next couple of weeks. Also, surely better to implement gen_conditional_store !USER, instead of duplicating the STCX macro. r~