From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42273) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VqLyM-0000Fm-GF for qemu-devel@nongnu.org; Tue, 10 Dec 2013 06:59:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VqLyF-0003Lv-P8 for qemu-devel@nongnu.org; Tue, 10 Dec 2013 06:59:30 -0500 Received: from mail-pb0-f48.google.com ([209.85.160.48]:56547) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VqLyF-0003Lp-Iz for qemu-devel@nongnu.org; Tue, 10 Dec 2013 06:59:23 -0500 Received: by mail-pb0-f48.google.com with SMTP id md12so7476121pbc.21 for ; Tue, 10 Dec 2013 03:59:22 -0800 (PST) Message-ID: <52A70213.50806@ozlabs.ru> Date: Tue, 10 Dec 2013 22:59:15 +1100 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <1374508822-15097-1-git-send-email-chouteau@adacore.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH V2] Add Enhanced Three-Speed Ethernet Controller (eTSEC) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf , Fabien Chouteau Cc: Scott Wood , Peter Crosthwaite , "qemu-ppc@nongnu.org list:PowerPC" , QEMU Developers On 12/10/2013 02:15 AM, Alexander Graf wrote: > > On 22.07.2013, at 18:00, Fabien Chouteau wrote: > >> This implementation doesn't include ring priority, TCP/IP Off-Load, QoS. >> >> Signed-off-by: Fabien Chouteau > > Thanks, applied to ppc-next. Could you please follow up with a patch that makes this available as -net nic,model=etsec and generate a respective device tree node for it? This does not compile: CC ppc-softmmu/hw/net/fsl_etsec/rings.o In file included from /home/alexey/p/qemu/hw/net/fsl_etsec/rings.c:24:0: /home/alexey/p/qemu/include/net/checksum.h:51:31: error: ‘struct iovec’ declared inside parameter list [-Werror] /home/alexey/p/qemu/include/net/checksum.h:51:31: error: its scope is only this definition or declaration, which is probably not what you want [-Werror] /home/alexey/p/qemu/hw/net/fsl_etsec/rings.c: In function ‘fill_rx_bd’: /home/alexey/p/qemu/hw/net/fsl_etsec/rings.c:396:5: error: format ‘%llx’ expects argument of type ‘long long unsigned int’, but argument 2 has type ‘hwaddr’ [-Werror=format] /home/alexey/p/qemu/hw/net/fsl_etsec/rings.c:396:5: error: format ‘%u’ expects argument of type ‘unsigned int’, but argument 3 has type ‘size_t’ [-Werror=format] /home/alexey/p/qemu/hw/net/fsl_etsec/rings.c: In function ‘etsec_walk_rx_ring’: /home/alexey/p/qemu/hw/net/fsl_etsec/rings.c:583:28: error: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘size_t’ [-Werror=format] /home/alexey/p/qemu/hw/net/fsl_etsec/rings.c:649:5: error: format ‘%u’ expects argument of type ‘unsigned int’, but argument 2 has type ‘size_t’ [-Werror=format] cc1: all warnings being treated as errors make[1]: *** [hw/net/fsl_etsec/rings.o] Error 1 make[1]: *** Waiting for unfinished jobs.... /home/alexey/p/qemu/hw/net/fsl_etsec/etsec.c: In function ‘etsec_realize’: /home/alexey/p/qemu/hw/net/fsl_etsec/etsec.c:389:53: error: ‘SysBusDevice’ has no member named ‘qdev’ make[1]: *** [hw/net/fsl_etsec/etsec.o] Error 1 make: *** [subdir-ppc-softmmu] Error 2 -- Alexey