From: Paolo Bonzini <pbonzini@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH rebased for-1.8] i386: pc: align gpa<->hpa on 1GB boundary (v6)
Date: Tue, 10 Dec 2013 14:18:36 +0100 [thread overview]
Message-ID: <52A714AC.3050703@redhat.com> (raw)
In-Reply-To: <20131128102652.GA24261@redhat.com>
Il 28/11/2013 11:26, Michael S. Tsirkin ha scritto:
> On Mon, Nov 25, 2013 at 06:43:13PM +0100, Paolo Bonzini wrote:
>> v2: condition enablement of new mapping to new machine types (Paolo)
>> v3: fix changelog
>> v4: rebase
>> v5: ensure alignment of piecetwo on 2MB GPA (Igor)
>> do not register zero-sized piece-one (Igor)
>> v6: fix memory leak (Igor)
>> fix integer overflow (Igor)
>>
>> ----
>>
>> Align guest physical address and host physical address
>> beyond guest 4GB on a 1GB boundary.
>>
>> Otherwise 1GB TLBs cannot be cached for the range.
>>
>> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
>> [Reorganize code, keep same logic. - Paolo]
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>
> Applied, thanks.
As discussed offlist, I'm not sure anymore that this is the right
approach to the problem. No doubt it is very clever, in that it is
absolutely transparent to the guest. However, the non-contiguous
mapping of ram_addr_t makes it more complex to associate the right NUMA
policy to the ranges.
If we could make a small guset visible change, it would be simpler to
always make the PCI hole 1GB in size; it is currently 256MB for i440FX
and 1.25GB for q35. We can take a look as soon as the SeaBIOS patches
are in to use QEMU-built ACPI tables.
Paolo
next prev parent reply other threads:[~2013-12-10 13:18 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-25 17:43 [Qemu-devel] [PATCH rebased for-1.8] i386: pc: align gpa<->hpa on 1GB boundary (v6) Paolo Bonzini
2013-11-25 20:58 ` Laszlo Ersek
2013-11-25 21:05 ` Michael S. Tsirkin
2013-11-25 23:09 ` Marcelo Tosatti
2013-11-26 9:04 ` Paolo Bonzini
2013-11-28 10:26 ` Michael S. Tsirkin
2013-12-10 13:18 ` Paolo Bonzini [this message]
2013-12-10 14:53 ` Gerd Hoffmann
2013-12-10 14:58 ` Paolo Bonzini
2013-12-10 15:36 ` Gerd Hoffmann
2013-12-10 15:47 ` Laszlo Ersek
2013-12-10 15:53 ` Gerd Hoffmann
2013-12-10 17:46 ` Laszlo Ersek
2013-12-10 17:48 ` Paolo Bonzini
2013-12-10 21:00 ` Michael S. Tsirkin
2013-12-10 22:13 ` Laszlo Ersek
2013-12-10 22:15 ` Laszlo Ersek
2013-12-10 23:17 ` Michael S. Tsirkin
2013-12-11 8:00 ` Gerd Hoffmann
2013-12-10 15:05 ` Marcelo Tosatti
2013-12-10 17:21 ` Marcelo Tosatti
2013-12-10 21:02 ` Michael S. Tsirkin
2013-12-11 13:41 ` Marcelo Tosatti
2013-12-11 14:20 ` Michael S. Tsirkin
2013-12-11 14:45 ` Paolo Bonzini
2013-12-11 15:39 ` Michael S. Tsirkin
2013-12-11 15:41 ` Paolo Bonzini
2013-12-11 15:51 ` Michael S. Tsirkin
2013-12-11 15:45 ` Igor Mammedov
2013-12-11 15:56 ` Paolo Bonzini
2013-12-11 17:26 ` Marcelo Tosatti
2013-12-10 16:52 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A714AC.3050703@redhat.com \
--to=pbonzini@redhat.com \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).