From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55499) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VqQdj-0001kV-Ei for qemu-devel@nongnu.org; Tue, 10 Dec 2013 11:58:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VqQdb-0000MQ-JD for qemu-devel@nongnu.org; Tue, 10 Dec 2013 11:58:31 -0500 Received: from mx1.redhat.com ([209.132.183.28]:1341) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VqQdb-0000MG-Aw for qemu-devel@nongnu.org; Tue, 10 Dec 2013 11:58:23 -0500 Message-ID: <52A7482B.302@redhat.com> Date: Tue, 10 Dec 2013 09:58:19 -0700 From: Eric Blake MIME-Version: 1.0 References: <1386598213-8156-1-git-send-email-akong@redhat.com> <1386598213-8156-3-git-send-email-akong@redhat.com> In-Reply-To: <1386598213-8156-3-git-send-email-akong@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="lOV8dU2IXXV85LMjT7smU00Gl7RN9oIk0" Subject: Re: [Qemu-devel] [PATCH RFC 2/2] rng-egd: introduce a parameter to set buffer size List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amos Kong , qemu-devel@nongnu.org Cc: amit.shah@redhat.com, varadgautam@gmail.com, anthony@codemonkey.ws This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --lOV8dU2IXXV85LMjT7smU00Gl7RN9oIk0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 12/09/2013 07:10 AM, Amos Kong wrote: > This patch makes the buffer size configurable, the max > buffer size is 65536. >=20 > -object rng-egd,chardev=3Dchr0,id=3Drng0,buf_size=3D1024 >=20 > Signed-off-by: Amos Kong > --- > backends/rng-egd.c | 24 +++++++++++++++++++++--- > 1 file changed, 21 insertions(+), 3 deletions(-) > @@ -281,6 +298,7 @@ static void rng_egd_init(Object *obj) > object_property_add_str(obj, "chardev", > rng_egd_get_chardev, rng_egd_set_chardev, > NULL); > + object_property_add_str(obj, "buf_size", NULL, rng_egd_set_buf_siz= e, NULL); > } Will libvirt ever need to set this property? And is it easily discoverable whether qemu supports or lacks this property? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --lOV8dU2IXXV85LMjT7smU00Gl7RN9oIk0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSp0grAAoJEKeha0olJ0Nq+cAIAKG8L+fv8vsHVclkLpTeHpkR Kk9Pz9mH59p3ynBwt6fnWVsDanMrA3+/ADakCugjuxOrU4/QLSq+pTqli6umpvD2 DwZ9H22M231Yy8VrkfL52qaLHY/a921OSV/l0uErWUH1A+cxKWeETZ5qpjGscJww EMtPTdKJLY3cOaHY1dkjNty77G58PYqLAUkJ2xcudqaDNq9tUsPQeWwkaVXtVY7o +K6gZo4JHgaCv8Y07ngQsjoQtRL+ZIx5KQO7Q6/fSoSdk5vMVmTWKgAOoWV8hlKu lmmXBWdgEQeON6lkfVGDi6nO+K5Yd49GwVZJT1JN/fFpiDe4hSg5iqtOtKTggvw= =Igm7 -----END PGP SIGNATURE----- --lOV8dU2IXXV85LMjT7smU00Gl7RN9oIk0--