From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38594)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tommusta@gmail.com>) id 1VqRQ8-0005FY-V7
	for qemu-devel@nongnu.org; Tue, 10 Dec 2013 12:48:41 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <tommusta@gmail.com>) id 1VqRQ0-0007A0-It
	for qemu-devel@nongnu.org; Tue, 10 Dec 2013 12:48:32 -0500
Message-ID: <52A753BF.6050303@gmail.com>
Date: Tue, 10 Dec 2013 11:47:43 -0600
From: Tom Musta <tommusta@gmail.com>
MIME-Version: 1.0
References: <1386604035-2507-1-git-send-email-tommusta@gmail.com>
	<1386604035-2507-3-git-send-email-tommusta@gmail.com>
	<52A659CE.6090202@twiddle.net>
In-Reply-To: <52A659CE.6090202@twiddle.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 02/18] target-ppc: Add ISA2.06 bpermd
	Instruction
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>, qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org

On 12/9/2013 6:01 PM, Richard Henderson wrote:
> On 12/09/2013 07:46 AM, Tom Musta wrote:
>> +    for (i = 0; i < 8; i++) {
>> +        int index = (rs & (0xFFul) << (i*8)) >> (i*8);
> 
> This is a silly expression.  Better as
> 
>     int index = (rs >> (i * 8)) & 0xff;
> 
>> +                ra |= (1<<i);
> 
> Unnecessary parens, and missing spaces around the operator.


Thanks, as always, for reviewing.  I concur with most of the comments ...
will respond only to those that I either disagree with or have further
questions.