From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47369) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VqRxK-0000tm-5r for qemu-devel@nongnu.org; Tue, 10 Dec 2013 13:22:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VqRxF-0000rk-7v for qemu-devel@nongnu.org; Tue, 10 Dec 2013 13:22:50 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47842) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VqRxE-0000rd-Su for qemu-devel@nongnu.org; Tue, 10 Dec 2013 13:22:45 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBAIMh6w023120 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 10 Dec 2013 13:22:43 -0500 Message-ID: <52A75702.4000103@redhat.com> Date: Tue, 10 Dec 2013 11:01:38 -0700 From: Eric Blake MIME-Version: 1.0 References: <1386694828-19786-1-git-send-email-pbonzini@redhat.com> <1386694828-19786-6-git-send-email-pbonzini@redhat.com> In-Reply-To: <1386694828-19786-6-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xh5LL484wwIoNEsCXQqIVFIcP84heoBJs" Subject: Re: [Qemu-devel] [PATCH 5/5] monitor: add object-del (QMP) and object_del (HMP) command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: imammedo@redhat.com, akong@redhat.com, armbru@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --xh5LL484wwIoNEsCXQqIVFIcP84heoBJs Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 12/10/2013 10:00 AM, Paolo Bonzini wrote: > These two commands invoke the "unparent" method of Object. >=20 > Signed-off-by: Paolo Bonzini > --- > +++ b/qapi-schema.json > @@ -2779,6 +2779,20 @@ > 'gen': 'no' } > =20 > ## > +# @object_del: object-del, to match your commit message > +# > +# Remove a QOM object. > +# > +# @id: the name of the QOM object to remove > +# > +# Returns: Nothing on success > +# Error if @id is not a valid id for a QOM object > +# > +# Since: 2.0 > +## > +{ 'command': 'object_del', 'data': {'id': 'str'} } again, object-del > + > +-> { "execute": "object-del", "arguments": { "id": "rng1" } } > +<- { "return": {} } and fixing the json will make your example correct :) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --xh5LL484wwIoNEsCXQqIVFIcP84heoBJs Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSp1cCAAoJEKeha0olJ0Nq02YH/14cGKGhCmGeVG2LLaYDjnHa iPtz5MeE61DjX1+cH1DpYIbs/cwl61iC4xFzDZbO40PzCt+6iqxmLMdCwG7vUmxI u+d+2VLljZIE76oFtY5aNOd5B7EzfGc72aAEf4eq0pm6nu/tAeXDfX+UztQXbuTC Y6bdTzj87kyOgs4YZs9HoK1F7mP+Lap/wGzjs0wkVO5xsRAcs5Iy1m/Eo+iDmb3S i2GltflvJQhXwgojpSc8xEhlOBiUJVi/d2dUYm47Zfqy0xezWp3kugFCoy5wg7vX ir+fqOYfaW2t3m82dTdf/LC9KnFZGRdXTkWeQyFDKE2yZA0nHv25V/WIvZNvnFY= =mI1d -----END PGP SIGNATURE----- --xh5LL484wwIoNEsCXQqIVFIcP84heoBJs--