From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42763)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VqRfI-0004wB-24
	for qemu-devel@nongnu.org; Tue, 10 Dec 2013 13:04:16 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VqRfD-0003cM-Fd
	for qemu-devel@nongnu.org; Tue, 10 Dec 2013 13:04:12 -0500
Received: from mx1.redhat.com ([209.132.183.28]:45133)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VqRfD-0003cG-8r
	for qemu-devel@nongnu.org; Tue, 10 Dec 2013 13:04:07 -0500
Message-ID: <52A75786.3060307@redhat.com>
Date: Tue, 10 Dec 2013 19:03:50 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1386143939-19142-1-git-send-email-gaowanlong@cn.fujitsu.com>
	<1386143939-19142-3-git-send-email-gaowanlong@cn.fujitsu.com>
	<20131210131548.GE27737@otherpad.lan.raisama.net>
In-Reply-To: <20131210131548.GE27737@otherpad.lan.raisama.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH V17 02/11] NUMA: check if the total numa
 memory size is equal to ram_size
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: drjones@redhat.com, jyang@redhat.com, libvir-list@redhat.com, hutao@cn.fujitsu.com, mtosatti@redhat.com, qemu-devel@nongnu.org, peter.huangpeng@huawei.com, bsd@redhat.com, anthony@codemonkey.ws, mkletzan@redhat.com, y-goto@jp.fujitsu.com, lcapitulino@redhat.com, lersek@redhat.com, afaerber@suse.de, Wanlong Gao <gaowanlong@cn.fujitsu.com>

Il 10/12/2013 14:15, Eduardo Habkost ha scritto:
>> > If the total number of the assigned numa nodes memory is not
>> > equal to the assigned ram size, it will write the wrong data
>> > to ACPI talb, then the guest will ignore the wrong ACPI table
>> > and recognize all memory to one node. It's buggy, we should
>> > check it to ensure that we write the right data to ACPI table.
>> > 
>> > Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
> This will make configurations that could be running for years (except
> that the guest OS was ignoring the NUMA data) suddenly stop running. I
> just want to confirm: we really want that, right?
> 
> Does libvirt allow this kind of broken configuration to be generated, or
> it already ensures the total NUMA node sizes match RAM size?

It allows this.  It just converts the <numa> XML to "-numa node".

Paolo