From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45871)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VqRsD-0003Y3-Pc
	for qemu-devel@nongnu.org; Tue, 10 Dec 2013 13:17:39 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VqRs7-0007bv-Qz
	for qemu-devel@nongnu.org; Tue, 10 Dec 2013 13:17:33 -0500
Received: from mx1.redhat.com ([209.132.183.28]:36614)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VqRs7-0007be-IY
	for qemu-devel@nongnu.org; Tue, 10 Dec 2013 13:17:27 -0500
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBAIHQ96006905
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 10 Dec 2013 13:17:27 -0500
Message-ID: <52A75AB3.4010400@redhat.com>
Date: Tue, 10 Dec 2013 19:17:23 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1386694828-19786-1-git-send-email-pbonzini@redhat.com>
	<1386694828-19786-6-git-send-email-pbonzini@redhat.com>
	<52A75702.4000103@redhat.com>
In-Reply-To: <52A75702.4000103@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 5/5] monitor: add object-del (QMP) and
 object_del (HMP) command
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: lcapitulino@redhat.com, imammedo@redhat.com, akong@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com

Il 10/12/2013 19:01, Eric Blake ha scritto:
> On 12/10/2013 10:00 AM, Paolo Bonzini wrote:
>> These two commands invoke the "unparent" method of Object.
>>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
> 
>> +++ b/qapi-schema.json
>> @@ -2779,6 +2779,20 @@
>>    'gen': 'no' }
>>  
>>  ##
>> +# @object_del:
> 
> object-del, to match your commit message
> 
>> +#
>> +# Remove a QOM object.
>> +#
>> +# @id: the name of the QOM object to remove
>> +#
>> +# Returns: Nothing on success
>> +#          Error if @id is not a valid id for a QOM object
>> +#
>> +# Since: 2.0
>> +##
>> +{ 'command': 'object_del', 'data': {'id': 'str'} }
> 
> again, object-del
> 
>> +
>> +-> { "execute": "object-del", "arguments": { "id": "rng1" } }
>> +<- { "return": {} }
> 
> and fixing the json will make your example correct :)

It actually worked and was tested, :) because 'command' is only used to
generate the marshaling function name (qmp_marshal_input_object_del).
qmp-commands.hx used the right name, and that's enough.

Of course this doesn't mean qapi-schema.json shouldn't be fixed.

Paolo