From: Eduardo Otubo <otubo@linux.vnet.ibm.com>
To: Lucas Meneghel Rodrigues <lmr@redhat.com>
Cc: pmoore@redhat.com, Corey Bryant <coreyb@linux.vnet.ibm.com>,
qemu-devel@nongnu.org, anthony@codemonkey.ws
Subject: Re: [Qemu-devel] [PATCH] seccomp: "-sandbox on" won't kill Qemu when option not built in
Date: Tue, 10 Dec 2013 17:35:33 -0200 [thread overview]
Message-ID: <52A76D05.2050906@linux.vnet.ibm.com> (raw)
In-Reply-To: <52A76216.7090303@redhat.com>
On 12/10/2013 04:48 PM, Lucas Meneghel Rodrigues wrote:
> On 12/10/2013 01:20 AM, Corey Bryant wrote:
>>>> IMHO the test suite should probe to see if sandbox is working or not,
>>>> and
>>>> just not use the "-sandbox on" arg if the host doesn't support it.
>>>
>>> But I think this could be done on virt-test as well :)
>>>
>>
>> This would make sense.
>>
>> Although it sounds like Lucas was looking for an error message when
>> seccomp kills qemu. Maybe virt-test could grep the audit log for the
>> existence of a "type=SECCOMP" record within the test's time of
>> execution, and issue a message based on that.
>
> It's a valid idea. The problem I see with it is that not every distro
> out there uses SELinux. Not getting into the merits of whether they
> should, ideally it'd be nice to have this working on distros that won't
> use SELinux.
>
>
>
Completely misunderstanding, I feel sorry for that.
While we can't rely on the fact that every distro will have audit log
working properly, I can start working on some support for virt-test to
detect if the host machine has support for seccomp or if the Qemu binary
has this feature built in.
Again, sorry for the mess. Please disconsider this patch.
--
Eduardo Otubo
IBM Linux Technology Center
next prev parent reply other threads:[~2013-12-10 19:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-09 17:20 [Qemu-devel] [PATCH] seccomp: "-sandbox on" won't kill Qemu when option not built in Eduardo Otubo
2013-12-09 17:33 ` Daniel P. Berrange
2013-12-09 17:51 ` Eduardo Otubo
2013-12-09 18:16 ` Paul Moore
2013-12-10 3:20 ` Corey Bryant
2013-12-10 18:48 ` Lucas Meneghel Rodrigues
2013-12-10 19:31 ` Paul Moore
2013-12-10 20:13 ` Lucas Meneghel Rodrigues
2013-12-10 19:35 ` Eduardo Otubo [this message]
2013-12-09 19:11 ` Lucas Meneghel Rodrigues
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A76D05.2050906@linux.vnet.ibm.com \
--to=otubo@linux.vnet.ibm.com \
--cc=anthony@codemonkey.ws \
--cc=coreyb@linux.vnet.ibm.com \
--cc=lmr@redhat.com \
--cc=pmoore@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).