From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49531) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VqVoK-0005g0-2T for qemu-devel@nongnu.org; Tue, 10 Dec 2013 17:29:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VqVoF-0007dr-F9 for qemu-devel@nongnu.org; Tue, 10 Dec 2013 17:29:48 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33339) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VqVoF-0007dn-6w for qemu-devel@nongnu.org; Tue, 10 Dec 2013 17:29:43 -0500 Message-ID: <52A795CF.3000400@redhat.com> Date: Tue, 10 Dec 2013 15:29:35 -0700 From: Eric Blake MIME-Version: 1.0 References: <1386635110-31990-1-git-send-email-a.motakis@virtualopensystems.com> <1386635110-31990-7-git-send-email-a.motakis@virtualopensystems.com> In-Reply-To: <1386635110-31990-7-git-send-email-a.motakis@virtualopensystems.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="QDUBj5B9cqrCunTSqUKuIAaId76NhNnHk" Subject: Re: [Qemu-devel] [PATCH 6/6] Add new vhost-user netdev backend List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Antonios Motakis , qemu-devel@nongnu.org, snabb-devel@googlegroups.com Cc: lukego@gmail.com, tech@virtualopensystems.com, n.nikolaev@virtualopensystems.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --QDUBj5B9cqrCunTSqUKuIAaId76NhNnHk Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 12/09/2013 05:25 PM, Antonios Motakis wrote: > Add a new QEMU netdev backend that is intended to invoke vhost_net > with the vhost-user backend. Also decouple virtio-net from the tap > backend. >=20 > Signed-off-by: Antonios Motakis > Signed-off-by: Nikolay Nikolaev > --- > +++ b/include/net/vhost-user.h > @@ -0,0 +1,17 @@ > +/* > + * vhost-user.h > + * > + * Copyright (c) 2013 Virtual Open Systems Sarl. > + * > + * This work is licensed under the terms of the GNU GPL, version 2. S= ee > + * the COPYING file in the top-level directory. Can you please use GPLv2+ (that is, add the "or later" clause)? Yes, we already have GPLv2-only files, but I'd like to avoid adding even more of them. > +++ b/net/vhost-user.c > @@ -0,0 +1,95 @@ > +/* > + * vhost-user.c > + * > + * Copyright (c) 2013 Virtual Open Systems Sarl. > + * > + * This work is licensed under the terms of the GNU GPL, version 2. S= ee > + * the COPYING file in the top-level directory. Same question applies to all new files added throughout this series. > +++ b/qapi-schema.json > @@ -3009,11 +3009,24 @@ > 'hubid': 'int32' } } > =20 > ## > +# @NetdevVhostUserOptions > +# > +# Vhost-user network backend > +# > +# @file: control socket path What does it mean when 'file' is not present? Is there a default value? Normally, we mark '#optional' in the docs for an optional argument. > +# > +# Since 2.0 > +## > +{ 'type': 'NetdevVhostUserOptions', > + 'data': { > + '*file': 'str' } } Or is file always present, in which case this should be 'file' instead of '*file'? > + > +## > # @NetClientOptions > # > # A discriminated record of network device traits. > # > -# Since 1.2 > +# Since 2.0 Wrong. NetClientOptions has existed since 1.2; but some of the branches of the union are newer. The way we have documented that elsewhere looks more like: # A discriminated record of network device traits. # @vde: traits for VDE # @dump: traits when using the device to dump all traffic # @bridge: traits for a bridge device # @hubport: traits for a hub port # @vhost-user: traits for a vhost-user (since 2.0) # # Since 1.2 > ## > { 'union': 'NetClientOptions', > 'data': { > @@ -3025,7 +3038,8 @@ > 'vde': 'NetdevVdeOptions', > 'dump': 'NetdevDumpOptions', > 'bridge': 'NetdevBridgeOptions', > - 'hubport': 'NetdevHubPortOptions' } } > + 'hubport': 'NetdevHubPortOptions', > + 'vhost-user': 'NetdevVhostUserOptions' } } > =20 > ## > # @NetLegacy >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --QDUBj5B9cqrCunTSqUKuIAaId76NhNnHk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSp5XQAAoJEKeha0olJ0NqAvwH/0I+Dfgmo9cubHLVfBOThyXN AWD7e+KQ5xRhFWk7h5/LEhgfyeSEInIt5OHZZ6WZnK0xD+2pGc6hteTpJ8pUA3on LwIj36Xqkap/lHN8cL+AIy5kE1G+JvhxBN04FWtbs5nLHtLxXhRJysFa74qLimvX 98o9neiaxvHe7jUZp5IW8tmkeO1i6dACUpO4qO/+lk3WFELMq0Vn5fPVD2rJnWk5 eNQB5c8jqGdUOV3XZNVrqUkg59gFI4Wm07y1bWFkTLqjX4ssZ7CtVbdnvwLjqK0D i+uz51Mr3K2aw1jwgXvamPi0DWKi9ncXQlKHO3MOREr8MZKIKWNrH4jJgtyA5vE= =nw7G -----END PGP SIGNATURE----- --QDUBj5B9cqrCunTSqUKuIAaId76NhNnHk--