Re: [Qemu-devel] [PATCH v3 1/5] boot: extend get_boot_devices_list() to ignore suffixes

[Alexey Kardashevskiy <aik@ozlabs.ru>]

On 12/10/2013 08:21 PM, Paolo Bonzini wrote:
> Il 10/12/2013 08:32, Alexey Kardashevskiy ha scritto:
>> As suffixes do not make sense for sPAPR's device tree and
>> there is no way to filter them out on the BusState::get_fw_dev_path
>> level, let's add an ability for the external caller to specify
>> whether to apply suffixes or not.
>>
>> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> 
> SeaBIOS simply ignores unknown suffixes once it has recognized a part of
> the path.  Could SLOF do the same?

SeaBIOS does not need it. SLOF does not need it either. Who does need it?
What is it for after all? Commit 1ca4d09ae0bcc2fdd6aeef0fdc11f82394f7e757
"Add bootindex parameter to net/block/fd device" does not explain that at all.

SLOF cannot just ignore this, why? It is a part of a path, it should parse
tree to find the node OR if it fails, find the closest matching node and
pass the rest of the path as a package parameter. And we do not really plan
to implement this (no use) as this is purely QEMU stuff which we do not
really want to carry to SLOF.

I'd stick to my original patch (please :) ) or add yet another Interface
just to ignore the suffix or method (ugly as it will be called from a place
different than hw/core/qdev.c).


-- 
Alexey